From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Stephane Eranian <eranian@google.com>,
Andy Lutomirski <luto@kernel.org>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
Vince Weaver <vincent.weaver@maine.edu>,
Thomas Gleixner <tglx@linutronix.de>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCHv2 0/8] perf/x86: Rework msr probe interface
Date: Fri, 14 Jun 2019 14:37:15 +0200 [thread overview]
Message-ID: <20190614123715.GN3436@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20190614102046.GB4325@krava>
On Fri, Jun 14, 2019 at 12:20:46PM +0200, Jiri Olsa wrote:
> On Fri, May 31, 2019 at 02:09:50PM +0200, Jiri Olsa wrote:
> > hi,
> > following up on [1], [2] and [3], this patchset adds update
> > attribute groups to pmu, factors out the MSR probe code and
> > use it in msr,cstate* and rapl PMUs.
> >
> > The functionality stays the same with one exception:
> > for msr PMU: the event is not exported if the rdmsr return zero
> > on event's msr, cstate* and rapl pmu functionality stays.
> >
> > And also: ;-)
> > > Somewhere along the line you lost the explanation of _why_ we're doing
> > > this; namely: virt sucks.
> >
> > Also available in:
> > git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
> > perf/msr
> >
> > Tested on snb and skylake servers.
> >
> > v2 changes:
> > - checking zero rdmsr only for msr PMU events,
> > cstate* and rapl pmu functionality stays unchanged
>
> ping
I was waiting a new post because you mentioned something about some
people not being happy with this, something about a wonky BIOS failing
this on native.
next prev parent reply other threads:[~2019-06-14 12:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 12:09 [PATCHv2 0/8] perf/x86: Rework msr probe interface Jiri Olsa
2019-05-31 12:09 ` [PATCH 1/8] perf/x86: Add " Jiri Olsa
2019-05-31 12:09 ` [PATCH 2/8] perf/x86/msr: Use new probe function Jiri Olsa
2019-05-31 12:09 ` [PATCH 3/8] perf/x86/cstate: " Jiri Olsa
2019-05-31 12:09 ` [PATCH 4/8] perf/x86/rapl: Use new msr detection interface Jiri Olsa
2019-05-31 12:09 ` [PATCH 5/8] perf/x86/rapl: Get rapl_cntr_mask from new probe framework Jiri Olsa
2019-05-31 12:09 ` [PATCH 6/8] perf/x86/rapl: Get msr values " Jiri Olsa
2019-05-31 12:09 ` [PATCH 7/8] perf/x86/rapl: Get attributes " Jiri Olsa
2019-05-31 12:09 ` [PATCH 8/8] perf/x86/rapl: Get quirk state " Jiri Olsa
2019-06-14 10:20 ` [PATCHv2 0/8] perf/x86: Rework msr probe interface Jiri Olsa
2019-06-14 12:37 ` Peter Zijlstra [this message]
2019-06-14 13:21 ` Jiri Olsa
2019-06-14 13:26 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614123715.GN3436@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=tglx@linutronix.de \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).