From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Benson Leung <bleung@google.com>
Cc: Enrico Granata <egranata@google.com>,
Ting Shen <phoenixshen@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
Nicolas Boichat <drinkcat@chromium.org>,
Pi-Hsun Shih <pihsun@chromium.org>,
Enrico Granata <egranata@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Heiko Stuebner <heiko@sntech.de>,
Guenter Roeck <groeck@chromium.org>,
Brian Norris <briannorris@chromium.org>,
Benson Leung <bleung@chromium.org>,
linux-input@vger.kernel.org,
Colin Ian King <colin.king@canonical.com>,
gwendal@chromium.org, Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH] Input: cros_ec_keyb: mask out extra flags in event_type
Date: Fri, 14 Jun 2019 12:19:02 -0700 [thread overview]
Message-ID: <20190614191902.GA150432@dtor-ws> (raw)
In-Reply-To: <20190614190957.GA243443@google.com>
On Fri, Jun 14, 2019 at 12:09:57PM -0700, Benson Leung wrote:
> Hi Dmitry,
>
> On Fri, Jun 14, 2019 at 11:55:33AM -0700, Dmitry Torokhov wrote:
> > On Fri, Jun 14, 2019 at 11:27:03AM -0700, Enrico Granata wrote:
> > > On Thu, Jun 13, 2019 at 11:54 PM Ting Shen <phoenixshen@chromium.org> wrote:
> > > >
> > > > http://crosreview.com/1341159 added a EC_MKBP_HAS_MORE_EVENTS flag to
> > > > the event_type field, the receiver side should mask out this extra bit when
> > > > processing the event.
> > > >
> > > > Signed-off-by: Ting Shen <phoenixshen@chromium.org>
> > >
> > > Reviewed-by: Enrico Granata <egranata@google.com>
> >
> > EC_MKBP_EVENT_TYPE_MASK is not in Linus' tree. It would be better to
> > merge this path through whatever tree that is bringing in that
> > definition.
> >
> > Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> Yup, this looks like it's coming in through Lee's MFD tree, a series from
> Gwendal to update cros_ec_commands.h.
>
> 784dd15c930f mfd: cros_ec: Fix event processing API
>
> That commit is in the immutable branch for v5.3 here:
> git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-cros-v5.3
>
> I'd recommend the chrome-platform tree since we'll be pulling in that IB too
> for some other refactoring Enric is working on.
Yeah, I'm fine with this going through chrome-platform.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2019-06-14 19:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 6:54 [PATCH] Input: cros_ec_keyb: mask out extra flags in event_type Ting Shen
2019-06-14 18:27 ` Enrico Granata
2019-06-14 18:55 ` Dmitry Torokhov
2019-06-14 19:09 ` Benson Leung
2019-06-14 19:19 ` Dmitry Torokhov [this message]
2019-06-14 19:32 ` Benson Leung
2019-06-18 8:43 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614191902.GA150432@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=bleung@chromium.org \
--cc=bleung@google.com \
--cc=briannorris@chromium.org \
--cc=colin.king@canonical.com \
--cc=drinkcat@chromium.org \
--cc=egranata@chromium.org \
--cc=egranata@google.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phoenixshen@chromium.org \
--cc=pihsun@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).