From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E46B6C31E4B for ; Fri, 14 Jun 2019 20:38:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB3832184B for ; Fri, 14 Jun 2019 20:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560544693; bh=zAHSL8lMf9ibQlvky8Qqu2bROjW1/JN7MkBf5X00ZA0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=PgRVrkoiHuI7sW1rJT0JBsntzRtH6wX4TmLNEoDjnf/fj1NCk9vGHu6mvfLFuvsug M5ZqEZsODjAlpaiaE/RJDoA83+vy9CwOw64G8LHLd/FYmduBoevKNfGElRGreiCrSR xY52I2mrP8eG3vjJd6BhTvMdnoRMQO95rrd+149g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727747AbfFNUiL (ORCPT ); Fri, 14 Jun 2019 16:38:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:50888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726732AbfFNU3D (ORCPT ); Fri, 14 Jun 2019 16:29:03 -0400 Received: from sasha-vm.mshome.net (unknown [131.107.159.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EA0052184E; Fri, 14 Jun 2019 20:29:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560544143; bh=zAHSL8lMf9ibQlvky8Qqu2bROjW1/JN7MkBf5X00ZA0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OXl6T011IuJCdTP69Y/J1W8wZPQ6WKTCKQ/J5NyaAukULcUbiHB4smxidvi+WkW3c RAa4MyLclGQCTA5LoLfyO6POBh+H6orNjPK8Ggk7eGXCkZ0zmXDzlv8qmoj3oOyLaE 6WvF+Gvpf9YodK05tji1hEVRji/G/dV6M7dVIrFk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Kamenee Arumugam , "Michael J . Ruhl" , Dennis Dalessandro , Jason Gunthorpe , Sasha Levin , linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 5.1 24/59] IB/hfi1: Validate page aligned for a given virtual address Date: Fri, 14 Jun 2019 16:28:08 -0400 Message-Id: <20190614202843.26941-24-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190614202843.26941-1-sashal@kernel.org> References: <20190614202843.26941-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kamenee Arumugam [ Upstream commit 97736f36dbebf2cda2799db3b54717ba5b388255 ] User applications can register memory regions for TID buffers that are not aligned on page boundaries. Hfi1 is expected to pin those pages in memory and cache the pages with mmu_rb. The rb tree will fail to insert pages that are not aligned correctly. Validate whether a given virtual address is page aligned before pinning. Fixes: 7e7a436ecb6e ("staging/hfi1: Add TID entry program function body") Reviewed-by: Michael J. Ruhl Signed-off-by: Kamenee Arumugam Signed-off-by: Dennis Dalessandro Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/hfi1/user_exp_rcv.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/infiniband/hw/hfi1/user_exp_rcv.c b/drivers/infiniband/hw/hfi1/user_exp_rcv.c index 0cd71ce7cc71..3592a9ec155e 100644 --- a/drivers/infiniband/hw/hfi1/user_exp_rcv.c +++ b/drivers/infiniband/hw/hfi1/user_exp_rcv.c @@ -324,6 +324,9 @@ int hfi1_user_exp_rcv_setup(struct hfi1_filedata *fd, u32 *tidlist = NULL; struct tid_user_buf *tidbuf; + if (!PAGE_ALIGNED(tinfo->vaddr)) + return -EINVAL; + tidbuf = kzalloc(sizeof(*tidbuf), GFP_KERNEL); if (!tidbuf) return -ENOMEM; -- 2.20.1