From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B23EC31E4B for ; Fri, 14 Jun 2019 20:56:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 217A52168B for ; Fri, 14 Jun 2019 20:56:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DZK18+j/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726187AbfFNU4T (ORCPT ); Fri, 14 Jun 2019 16:56:19 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:45502 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbfFNU4T (ORCPT ); Fri, 14 Jun 2019 16:56:19 -0400 Received: by mail-pg1-f196.google.com with SMTP id s21so2164273pga.12; Fri, 14 Jun 2019 13:56:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Yne9fkU6wE/82N/AFeecOPZEhmtxL6CFlvongVG7mfE=; b=DZK18+j/Zl+kVuDlssgW7C9bDCoD1Qr+/Mmke0JecU4VD4daD2/SUDN3/4UOWFDeUI CsLNIKid5hnOv8RX8ROzGtFNVPZW7izEXTz+JkZ43/Ia0Xq6A1+W92ObG/VwuM4hB+Ny uOh/I6BFWw1ds5ZZws3gfzSBzFYdhDVX/D6JVykAcbve6VObBW2ET0dmx3WxSNn0bL/r YDXaPKAPKH150QgCqmFSLdewyGVGOB8KsREwIDh8RGLVGiw343ts1MHXfFYPrUN83rGF v/stxJCqMWqUfgWF6JqqZIEG/4YxONKFqeBYEGIH/Exr4UK7BbWM8C77hvMWAqEcSW6T n/0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Yne9fkU6wE/82N/AFeecOPZEhmtxL6CFlvongVG7mfE=; b=g2jcfqD3a+TDoN+96ZjXBC8gwWmYluMHKh43A8N7Dh5C/oa9JZIU1UXsVZ1cJ20ytA BXhf6wN6ML1k7sBG9H1U2Mkohj+WaeFUN1C67M+6tmlAXvxUW2cNlIcM0bjB11NT9tg8 ZJlIFeDL5Z+eT5G2EPckHGAp0f3S74aE99/IqfAWIB5CZWDWc/cJgTCisDLVlMBVafCp Di6SO1xeio5goVk4xVcd223uOlLY7e1F1GK0JktYt74IcyODXyilUfHZPxGN3i459PK/ 6qoTlnzxeLqiJJ1S8PJO9Yfv+7atMKN/93343zWeYUnfspWWKScqxbRPUpJKur5LrX4t PXZQ== X-Gm-Message-State: APjAAAWGYlTBYGEDHe9SfYKzGH86wtJ/YRQDymQQizU2t96l2lMXoedR nddbdVu4tU/OV6nf11USCNc= X-Google-Smtp-Source: APXvYqz8fF3d09X3S5MDTl9m8/QKwwEvli9hG2LfLqQI22wUh+UIK5jKnhAhsQgDhY1T7Z/EgREJ0A== X-Received: by 2002:a63:fb4b:: with SMTP id w11mr3077734pgj.415.1560545778214; Fri, 14 Jun 2019 13:56:18 -0700 (PDT) Received: from ast-mbp.dhcp.thefacebook.com ([2620:10d:c090:200::1:6345]) by smtp.gmail.com with ESMTPSA id y185sm3781367pfy.110.2019.06.14.13.56.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Jun 2019 13:56:17 -0700 (PDT) Date: Fri, 14 Jun 2019 13:56:15 -0700 From: Alexei Starovoitov To: Josh Poimboeuf Cc: x86@kernel.org, Alexei Starovoitov , linux-kernel@vger.kernel.org, Daniel Borkmann , netdev@vger.kernel.org, bpf@vger.kernel.org, Peter Zijlstra , Song Liu , Kairui Song , Steven Rostedt , David Laight , Thomas Gleixner , Borislav Petkov , Ingo Molnar Subject: Re: [PATCH v2 1/5] perf/x86: Always store regs->ip in perf_callchain_kernel() Message-ID: <20190614205614.zr6awljx3qdg2fnb@ast-mbp.dhcp.thefacebook.com> References: <81b0cdc5aa276dac315a0536df384cc82da86243.1560534694.git.jpoimboe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81b0cdc5aa276dac315a0536df384cc82da86243.1560534694.git.jpoimboe@redhat.com> User-Agent: NeoMutt/20180223 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 14, 2019 at 12:56:40PM -0500, Josh Poimboeuf wrote: > From: Song Liu > > The stacktrace_map_raw_tp BPF selftest is failing because the RIP saved > by perf_arch_fetch_caller_regs() isn't getting saved by > perf_callchain_kernel(). > > This was broken by the following commit: > > d15d356887e7 ("perf/x86: Make perf callchains work without CONFIG_FRAME_POINTER") > > With that change, when starting with non-HW regs, the unwinder starts > with the current stack frame and unwinds until it passes up the frame > which called perf_arch_fetch_caller_regs(). So regs->ip needs to be > saved deliberately. > > Fixes: d15d356887e7 ("perf/x86: Make perf callchains work without CONFIG_FRAME_POINTER") > Signed-off-by: Josh Poimboeuf > Acked-by: Peter Zijlstra (Intel) It's not cool to remove people's SOB. It's Song's patch. His should be first and your second.