From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93FD2C31E52 for ; Fri, 14 Jun 2019 23:17:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7593121848 for ; Fri, 14 Jun 2019 23:17:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726185AbfFNXR1 (ORCPT ); Fri, 14 Jun 2019 19:17:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45108 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbfFNXR0 (ORCPT ); Fri, 14 Jun 2019 19:17:26 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 31D74368E3; Fri, 14 Jun 2019 23:17:26 +0000 (UTC) Received: from treble (ovpn-112-39.rdu2.redhat.com [10.10.112.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0C2B65C29A; Fri, 14 Jun 2019 23:17:20 +0000 (UTC) Date: Fri, 14 Jun 2019 18:17:17 -0500 From: Josh Poimboeuf To: Alexei Starovoitov Cc: X86 ML , Alexei Starovoitov , LKML , Daniel Borkmann , Network Development , bpf , Peter Zijlstra , Song Liu , Kairui Song , Steven Rostedt , David Laight , Thomas Gleixner , Borislav Petkov , Ingo Molnar Subject: Re: [PATCH v2 2/5] objtool: Fix ORC unwinding in non-JIT BPF generated code Message-ID: <20190614231717.xukbfpc2cy47s4xh@treble> References: <20190614205841.s4utbpurntpr6aiq@ast-mbp.dhcp.thefacebook.com> <20190614210745.kwiqm5pkgabruzuj@treble> <20190614211929.drnnawbi7guqj2ck@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 14 Jun 2019 23:17:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 14, 2019 at 02:22:59PM -0700, Alexei Starovoitov wrote: > On Fri, Jun 14, 2019 at 2:19 PM Josh Poimboeuf wrote: > > > > > > > > > > > > +#define JUMP_TABLE_SYM_PREFIX "jump_table." > > > > > > > > > > since external tool will be looking at it should it be named > > > > > "bpf_jump_table." to avoid potential name conflicts? > > > > > Or even more unique name? > > > > > Like "bpf_interpreter_jump_table." ? > > > > > > > > No, the point is that it's a generic feature which can also be used any > > > > non-BPF code which might also have a jump table. > > > > > > and you're proposing to name all such jump tables in the kernel > > > as static foo jump_table[] ? > > > > That's the idea. > > Then it needs much wider discussion. Why would it need wider discussion? It only has one user. If you honestly believe that it will be controversial to require future users to call a static jump table "jump_table" then we can have that discussion when it comes up. -- Josh