From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3BE9C46477 for ; Sat, 15 Jun 2019 05:48:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2DFD217D6 for ; Sat, 15 Jun 2019 05:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560577706; bh=3DxSOYcYTiNCBZltQK+f/JE8TaouzRRdRIXug1AbTS4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=eEyAGoQBNeuilFdTTXud+2ck6EfVTkh95mpvhYm7Q5moTcXMmrOXe/2pBV0//dJuP Hp1DbFQ8qsgdVDSLJXdrjrtvRfVLSiyBaVUJKVLACuQPHtE8NBoqo7evmh2LquyBma wZyhbaRPO6nzdOhIlI3c5U9oKohKFBLjLw0xSTFk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726351AbfFOFsJ (ORCPT ); Sat, 15 Jun 2019 01:48:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:41680 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725786AbfFOFsJ (ORCPT ); Sat, 15 Jun 2019 01:48:09 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E73742084D; Sat, 15 Jun 2019 05:48:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560577688; bh=3DxSOYcYTiNCBZltQK+f/JE8TaouzRRdRIXug1AbTS4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SSCcHS8Ad7sK9BOGqENrENG9D/84/1dvBCklCyS2jgSP9VLo03lON6ojHV2bZtLTv 3I88mNwtafte2QTZuVd0ogzkpitbnQyA7sBpX/k6WIITqxZjyIzjHKXnfTDvoAwzes te2urnXh1Bcewp2SxwKWDYRbQ2qjVZi62wsgxf9I= Date: Sat, 15 Jun 2019 07:48:06 +0200 From: Greg Kroah-Hartman To: Sasha Levin Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Chengguang Xu , Wu Hao , Alan Tull , linux-fpga@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.1 17/59] fpga: dfl: expand minor range when registering chrdev region Message-ID: <20190615054806.GB23883@kroah.com> References: <20190614202843.26941-1-sashal@kernel.org> <20190614202843.26941-17-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190614202843.26941-17-sashal@kernel.org> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 14, 2019 at 04:28:01PM -0400, Sasha Levin wrote: > From: Chengguang Xu > > [ Upstream commit de9a7f6f5f1967d275311cca9163b4a3ffe9b0ae ] > > Actually, total amount of available minor number > for a single major is MINORMASK + 1. So expand > minor range when registering chrdev region. > > Signed-off-by: Chengguang Xu > Acked-by: Wu Hao > Acked-by: Alan Tull > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Sasha Levin > --- > drivers/fpga/dfl.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c > index c25217cde5ca..4b66aaa32b5a 100644 > --- a/drivers/fpga/dfl.c > +++ b/drivers/fpga/dfl.c > @@ -322,7 +322,7 @@ static void dfl_chardev_uinit(void) > for (i = 0; i < DFL_FPGA_DEVT_MAX; i++) > if (MAJOR(dfl_chrdevs[i].devt)) { > unregister_chrdev_region(dfl_chrdevs[i].devt, > - MINORMASK); > + MINORMASK + 1); > dfl_chrdevs[i].devt = MKDEV(0, 0); > } > } > @@ -332,8 +332,8 @@ static int dfl_chardev_init(void) > int i, ret; > > for (i = 0; i < DFL_FPGA_DEVT_MAX; i++) { > - ret = alloc_chrdev_region(&dfl_chrdevs[i].devt, 0, MINORMASK, > - dfl_chrdevs[i].name); > + ret = alloc_chrdev_region(&dfl_chrdevs[i].devt, 0, > + MINORMASK + 1, dfl_chrdevs[i].name); > if (ret) > goto exit; > } Not a bugfix, so not needed for stable kernels, thanks. greg k-h