Re: [PATCH 4.19 017/118] thermal: rcar_gen3_thermal: disable interrupt in .remove

[Pavel Machek <pavel@ucw.cz>]

[-- Attachment #1: Type: text/plain, Size: 1277 bytes --]

Hi!

stable removed from cc.


On Thu 2019-06-13 10:32:35, Greg Kroah-Hartman wrote:
> [ Upstream commit 63f55fcea50c25ae5ad45af92d08dae3b84534c2 ]
> 
> Currently IRQ remains enabled after .remove, later if device is probed,
> IRQ is requested before .thermal_init, this may cause IRQ function be
> called before device is initialized.
> 
> this patch disables interrupt in .remove, to ensure irq function
> only be called after device is fully initialized.

Well, I guess this fixes your problem, but it does not seem like a
correct fix.

Could .init be reordered so that you initialize hardware, first, and
only then request irq? That should solve the problem in a reliable
way.

Thanks,

								Pavel

> +++ b/drivers/thermal/rcar_gen3_thermal.c
> @@ -328,6 +328,9 @@ MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids);
>  static int rcar_gen3_thermal_remove(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
> +	struct rcar_gen3_thermal_priv *priv = dev_get_drvdata(dev);
> +
> +	rcar_thermal_irq_set(priv, false);
>  
>  	pm_runtime_put(dev);
>  	pm_runtime_disable(dev);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]