From: Matthias Kaehlcke <email@example.com> To: Pavel Machek <firstname.lastname@example.org> Cc: Heiko Stuebner <email@example.com>, Rob Herring <firstname.lastname@example.org>, Mark Rutland <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org, email@example.com, Enric Balletbo i Serra <firstname.lastname@example.org>, Douglas Anderson <email@example.com> Subject: Re: [PATCH] Revert "ARM: dts: rockchip: set PWM delay backlight settings for Minnie" Date: Mon, 17 Jun 2019 09:16:25 -0700 Message-ID: <20190617161625.GR137143@google.com> (raw) In-Reply-To: <20190616154143.GA28583@atrey.karlin.mff.cuni.cz> Hi Pavel, On Sun, Jun 16, 2019 at 05:41:43PM +0200, Pavel Machek wrote: > Hi! > > > This reverts commit 288ceb85b505c19abe1895df068dda5ed20cf482. > > > > According to the commit message the AUO B101EAN01 panel on minnie > > requires a PWM delay of 200 ms, however this is not what the > > datasheet says. The datasheet mentions a *max* delay of 200 ms > > for T2 ("delay from LCDVDD to black video generation") and T3 > > ("delay from LCDVDD to HPD high"), which aren't related to the > > PWM. The backlight power sequence does not specify min/max > > constraints for T15 (time from PWM on to BL enable) or T16 > > (time from BL disable to PWM off). > > > > Signed-off-by: Matthias Kaehlcke <firstname.lastname@example.org> > > --- > > Enric, if you think I misinterpreted the datasheet please holler! > > Was this tested? I performed limited manually testing. minnie ships with the Chrome OS 3.14 downstream, which doesn't include this delay, to my knowledge there are no open display related bugs for minnie. One could argue that a the configuration without the delay was widely field tested > Does patch being reverted actually break anything? To my knowledge it doesn't really break anything, however there is a short user perceptible delay between switching on the LCD and switching on the backlight. It's not the end of the world, but if it's not actually needed better avoid it. > If so, cc stable? I guess this is an edge case, were you could go either way. I'm fine with respinning and cc-ing stable.
next prev parent reply index Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-14 22:45 Matthias Kaehlcke 2019-06-16 15:41 ` Pavel Machek 2019-06-17 10:08 ` Enric Balletbo i Serra 2019-06-17 16:30 ` Matthias Kaehlcke 2019-06-17 16:16 ` Matthias Kaehlcke [this message] 2019-06-18 12:02 ` Pavel Machek 2019-06-18 8:21 ` Enric Balletbo i Serra 2019-06-18 18:34 ` Matthias Kaehlcke
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190617161625.GR137143@google.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ firstname.lastname@example.org email@example.com public-inbox-index lkml Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/ public-inbox