From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D17BFC31E5B for ; Tue, 18 Jun 2019 16:48:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AEF032084B for ; Tue, 18 Jun 2019 16:48:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730114AbfFRQsB (ORCPT ); Tue, 18 Jun 2019 12:48:01 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49892 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729423AbfFRQsA (ORCPT ); Tue, 18 Jun 2019 12:48:00 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9DF711509C5C8; Tue, 18 Jun 2019 09:47:59 -0700 (PDT) Date: Tue, 18 Jun 2019 09:47:59 -0700 (PDT) Message-Id: <20190618.094759.539007481404905339.davem@davemloft.net> To: willemdebruijn.kernel@gmail.com Cc: gregkh@linuxfoundation.org, naresh.kamboju@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, fklassen@appneta.com Subject: Re: 4.19: udpgso_bench_tx: setsockopt zerocopy: Unknown error 524 From: David Miller In-Reply-To: References: <20190618161036.GA28190@kroah.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 18 Jun 2019 09:47:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Willem de Bruijn Date: Tue, 18 Jun 2019 12:37:33 -0400 > Specific to the above test, I can add a check command testing > setsockopt SO_ZEROCOPY return value. AFAIK kselftest has no explicit > way to denote "skipped", so this would just return "pass". Sounds a > bit fragile, passing success when a feature is absent. Especially since the feature might be absent because the 'config' template forgot to include a necessary Kconfig option.