linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Helmut Grohne <helmut.grohne@intenta.de>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: <tglx@linutronix.de>, <linux-kernel@vger.kernel.org>,
	David Abdurachmanov <david.abdurachmanov@gmail.com>,
	Palmer Dabbelt <palmer@sifive.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"open list:RISC-V ARCHITECTURE" <linux-riscv@lists.infradead.org>
Subject: Re: [PATCH 02/15] clocksource/drivers/sp804: Add COMPILE_TEST to CONFIG_ARM_TIMER_SP804
Date: Tue, 18 Jun 2019 14:07:21 +0200	[thread overview]
Message-ID: <20190618120719.a4kgyiuljm5uivfq@laureti-dev> (raw)
In-Reply-To: <20190509111048.11151-2-daniel.lezcano@linaro.org>

On Thu, May 09, 2019 at 01:10:35PM +0200, Daniel Lezcano wrote:
> From: David Abdurachmanov <david.abdurachmanov@gmail.com>
> 
> This is only used on arm and arm64 platforms. Add COMPILE_TEST option.

This patch breaks selecting CONFIG_ARM_TIMER_SP804 here. I don't quite
understand why, but commit dfc82faad72520769ca146f857e65c23632eed5a is
where bisection stops.

When I try make allnoconfig with a KCONFIG_ALLCONFIG that explicitly
enables this option, it remains disabled.

When I try make menuconfig, the clocksource menu is empty.

If I apply the patch below, the option is selectable in menuconfig and
with KCONFIG_ALLCONFIG again. It could be used as an alternative
implementation, but I don't have a good rationale for why the previous
approach breaks.

My reading of the kconfig documentation indicates that the "if
condition" should only influence the default value, but it seems like it
entirely disables the option here. I'm left wondering why.

Can we revert the patch until this is sorted out?

Helmut

--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -388,7 +388,8 @@ config ARM_GLOBAL_TIMER
 	  This options enables support for the ARM global timer unit
 
 config ARM_TIMER_SP804
-	bool "Support for Dual Timer SP804 module" if COMPILE_TEST
+	bool "Support for Dual Timer SP804 module"
+	depends on ARM || ARM64 || COMPILE_TEST
 	depends on GENERIC_SCHED_CLOCK && CLKDEV_LOOKUP
 	select CLKSRC_MMIO
 	select TIMER_OF if OF

  reply	other threads:[~2019-06-18 12:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09 11:08 [GIT PULL] timer drivers for 5.2 Daniel Lezcano
2019-05-09 11:10 ` [PATCH 01/15] clocksource/drivers/sun4i: Add a compatible for suniv Daniel Lezcano
2019-05-09 11:10   ` [PATCH 02/15] clocksource/drivers/sp804: Add COMPILE_TEST to CONFIG_ARM_TIMER_SP804 Daniel Lezcano
2019-06-18 12:07     ` Helmut Grohne [this message]
2019-05-09 11:10   ` [PATCH 03/15] clocksource/drivers/tegra: Rework for compensation of suspend time Daniel Lezcano
2019-05-09 11:10   ` [PATCH 04/15] clocksource/drivers/timer-milbeaut: Fix to enable one-shot timer Daniel Lezcano
2019-05-09 11:10   ` [PATCH 05/15] clocksource/drivers/timer-milbeaut: Add shutdown function Daniel Lezcano
2019-05-09 11:10   ` [PATCH 06/15] clocksource/drivers/timer-milbeaut: Cleanup common register accesses Daniel Lezcano
2019-05-09 11:10   ` [PATCH 07/15] ARM: at91: move SoC specific definitions to SoC folder Daniel Lezcano
2019-05-09 11:10   ` [PATCH 08/15] clocksource/drivers/tcb_clksrc: Stop depending on atmel_tclib Daniel Lezcano
2019-05-09 11:10   ` [PATCH 09/15] clocksource/drivers/tcb_clksrc: Use tcb as sched_clock Daniel Lezcano
2019-05-09 11:10   ` [PATCH 10/15] ARM: at91: Implement clocksource selection Daniel Lezcano
2019-05-09 11:10   ` [PATCH 11/15] clocksource/drivers/tcb_clksrc: Move Kconfig option Daniel Lezcano
2019-05-09 11:10   ` [PATCH 12/15] clocksource/drivers/timer-atmel-pit: Rework " Daniel Lezcano
2019-05-09 11:10   ` [PATCH 13/15] clocksource/drivers/tcb_clksrc: Rename the file for consistency Daniel Lezcano
2019-05-09 11:10   ` [PATCH 14/15] clocksource/drivers/timer-atmel-tcb: Convert tc_clksrc_suspend|resume() to static Daniel Lezcano
2019-05-09 11:10   ` [PATCH 15/15] misc: atmel_tclib: Do not probe already used TCBs Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190618120719.a4kgyiuljm5uivfq@laureti-dev \
    --to=helmut.grohne@intenta.de \
    --cc=aou@eecs.berkeley.edu \
    --cc=daniel.lezcano@linaro.org \
    --cc=david.abdurachmanov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@sifive.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).