From: Eric Biggers <ebiggers@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Eric Biggers <ebiggers@google.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Vitaly Chikunov <vt@altlinux.org>,
Gilad Ben-Yossef <gilad@benyossef.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] crypto: testmgr - dynamically allocate crypto_shash
Date: Tue, 18 Jun 2019 11:07:48 -0700 [thread overview]
Message-ID: <20190618180748.GI184520@gmail.com> (raw)
In-Reply-To: <20190618092215.2790800-2-arnd@arndb.de>
On Tue, Jun 18, 2019 at 11:21:53AM +0200, Arnd Bergmann wrote:
> The largest stack object in this file is now the shash descriptor.
> Since there are many other stack variables, this can push it
> over the 1024 byte warning limit, in particular with clang and
> KASAN:
>
> crypto/testmgr.c:1693:12: error: stack frame size of 1312 bytes in function '__alg_test_hash' [-Werror,-Wframe-larger-than=]
>
> Make test_hash_vs_generic_impl() do the same thing as the
> corresponding eaed and skcipher functions by allocating the
Typo: "eaed" should be "aead"
> descriptor dynamically. We can still do better than this,
> but it brings us well below the 1024 byte limit.
>
> Suggested-by: Eric Biggers <ebiggers@kernel.org>
> Fixes: 9a8a6b3f0950 ("crypto: testmgr - fuzz hashes against their generic implementation")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Actual patch looks fine though. Thanks!
Reviewed-by: Eric Biggers <ebiggers@kernel.org>
- Eric
next prev parent reply other threads:[~2019-06-18 18:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 9:21 [PATCH v2 1/2] crypto: testmgr - dynamically allocate testvec_config Arnd Bergmann
2019-06-18 9:21 ` [PATCH v2 2/2] crypto: testmgr - dynamically allocate crypto_shash Arnd Bergmann
2019-06-18 18:07 ` Eric Biggers [this message]
2019-06-18 18:06 ` [PATCH v2 1/2] crypto: testmgr - dynamically allocate testvec_config Eric Biggers
2019-06-28 4:18 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618180748.GI184520@gmail.com \
--to=ebiggers@kernel.org \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=gilad@benyossef.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vt@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).