On Wed, Jun 12, 2019 at 08:25:03AM -0300, Mauro Carvalho Chehab wrote: > As reported by Stephen: > > > After merging the i2c tree, today's linux-next build (x86_64 allmodconfig) > > produced this warning: > > > > drivers/media/dvb-frontends/tua6100.c: In function 'tua6100_set_params': > > drivers/media/dvb-frontends/tua6100.c:71: warning: "_P" redefined > > #define _P 32 > > > > In file included from include/acpi/platform/aclinux.h:54, > > from include/acpi/platform/acenv.h:152, > > from include/acpi/acpi.h:22, > > from include/linux/acpi.h:21, > > from include/linux/i2c.h:17, > > from drivers/media/dvb-frontends/tua6100.h:22, > > from drivers/media/dvb-frontends/tua6100.c:24: > > include/linux/ctype.h:14: note: this is the location of the previous definition > > #define _P 0x10 /* punct */ > > > > Exposed by commit > > > > 5213d7efc8ec ("i2c: acpi: export i2c_acpi_find_adapter_by_handle") > > > > Since that included from > > > > Originally introduced by commit > > > > 00be2e7c6415 ("V4L/DVB (4606): Add driver for TUA6100") > > > > The _P in has existed since before git. > > The addition of include at the I2C code caused a > breakage at the tua6100 driver. The reason is that the code there > used defines for 3 parameters used at the calculus for the > divide ratio. > > In thesis, those are board-dependent, but, as there's just one > driver using it (ttpci/budget-av), there was no need to make > the code more generic. While it sounds unlikely that this old > DVB-S frontend would ever be used on new projects, one might > some day come with a variant using a different configuration. So, > let's do the right thing and store those values at its private > struct. > > Reported-by: Stephen Rothwell > Signed-off-by: Mauro Carvalho Chehab I see there is a build-fix from davem now in linux-next. Shall I still apply this patch to my i2c tree once Mauro applied it to his?