From: Peter Zijlstra <peterz@infradead.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
Andrew Morton <akpm@linux-foundation.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"# 3.4.x" <stable@vger.kernel.org>
Subject: Re: [PATCH] ubsan: mark ubsan_type_mismatch_common inline
Date: Wed, 19 Jun 2019 09:57:03 +0200 [thread overview]
Message-ID: <20190619075703.GK3419@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAK8P3a1ZgSYMuD0Xy_fxTqzPhg=U6rqG2Lcfc+3Bni=ZijiE3A@mail.gmail.com>
On Tue, Jun 18, 2019 at 05:06:39PM +0200, Arnd Bergmann wrote:
> On Tue, Jun 18, 2019 at 3:59 PM Peter Zijlstra <peterz@infradead.org> wrote:
> > On Tue, Jun 18, 2019 at 04:27:45PM +0300, Andrey Ryabinin wrote:
> > > On 6/18/19 3:56 PM, Arnd Bergmann wrote:
> > > > On Mon, Jun 17, 2019 at 4:02 PM Peter Zijlstra <peterz@infradead.org> wrote:
>
> > > I guess this:
> > > ccflags-y += $(DISABLE_STACKLEAK_PLUGIN)
> >
> > Or more specifically this, I guess:
> >
> > CFLAGS_ubsan.o := $(call cc-option, -fno-conserve-stack -fno-stack-protector) $(DISABLE_STACKLEAK_PLUGIN)
> >
> > we'd not want to exclude all of lib/ from stackleak I figure.
> >
> > Of these two options, I think I prefer the latter, because a smaller
> > whitelist is a better whitelist and since we already disable
> > stack protector, it is only consistent to also disable stack leak.
>
> Ok, sounds good to me. Can you send that upstream then, or should
> I write it up as a proper patch?
If you could verify it actually works that would be great, I haven't
tried to construct a failing .config yet.
prev parent reply other threads:[~2019-06-19 7:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 12:31 [PATCH] ubsan: mark ubsan_type_mismatch_common inline Arnd Bergmann
2019-06-17 14:02 ` Peter Zijlstra
2019-06-18 12:56 ` Arnd Bergmann
2019-06-18 13:27 ` Andrey Ryabinin
2019-06-18 13:59 ` Peter Zijlstra
2019-06-18 15:06 ` Arnd Bergmann
2019-06-19 7:57 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619075703.GK3419@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).