From: Mark Brown <broonie@kernel.org>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH 1/3] include: linux: spi: more helpers for declaring spi drivers
Date: Wed, 19 Jun 2019 13:14:41 +0100 [thread overview]
Message-ID: <20190619121441.GS5316@sirena.org.uk> (raw)
In-Reply-To: <1560796840-18207-1-git-send-email-info@metux.net>
[-- Attachment #1: Type: text/plain, Size: 825 bytes --]
On Mon, Jun 17, 2019 at 08:40:38PM +0200, Enrico Weigelt, metux IT consult wrote:
> +/* subsys_spi_driver() - Helper macro for drivers that don't do
> + * anything special in module init/exit. This eliminates a lot of
> + * boilerplate. Each module may only use this macro once, and
> + * calling it replaces subsys_initcall() and module_exit()
> + */
> +#define subsys_spi_driver(__spi_driver) \
I'm not convinced we want to be encouraging anyone to be using
subsys_initcall() for SPI drivers in the first place - my guess would be
that with deferred probing none of that is needed anyway and the driver
could just use module_spi_driver(). Certainly if the drivers do
actually need subsys_initcall() I'd like to understand why before going
forward with something like this, and ideally we'd be able to remove the
need.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-06-19 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 18:40 [PATCH 1/3] include: linux: spi: more helpers for declaring spi drivers Enrico Weigelt, metux IT consult
2019-06-17 18:40 ` [PATCH 2/3] drivers: gpio: pcf857x: use subsys_spi_driver() Enrico Weigelt, metux IT consult
2019-06-18 13:48 ` Geert Uytterhoeven
2019-06-17 18:40 ` [PATCH 3/3] drivers: gpio: mc33880: " Enrico Weigelt, metux IT consult
2019-06-19 12:14 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190619121441.GS5316@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=info@metux.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).