From: Ondrej Zary <linux@zary.sk>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Hannes Reinecke <hare@suse.com>,
Johannes Thumshirn <jthumshirn@suse.de>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: fdomain: fix building pcmcia front-end
Date: Wed, 19 Jun 2019 20:36:37 +0200 [thread overview]
Message-ID: <201906192036.37384.linux@zary.sk> (raw)
In-Reply-To: <yq1v9x2uv2a.fsf@oracle.com>
On Wednesday 19 June 2019 05:13:01 Martin K. Petersen wrote:
>
> Arnd,
>
> > Move the common support outside of the SCSI_LOWLEVEL section.
> > Alternatively, we could move all of SCSI_LOWLEVEL_PCMCIA into
> > SCSI_LOWLEVEL. This would be more sensible, but might cause surprises
> > for users that have SCSI_LOWLEVEL disabled.
>
> It seems messy to me that PCMCIA lives outside of the LOWLEVEL section.
>
> Given that the number of users that rely on PCMCIA for their system disk
> is probably pretty low, I think I'm leaning towards cleaning things up
> instead of introducing a nonsensical top level option.
>
> Or even better: Get rid of SCSI_FDOMAIN as a user-visible option and
> select it if either of the PCI/ISA/PCMCIA drivers are enabled.
SCSI_FDOMAIN is not an user-visible option. PCI/ISA/PCMCIA drivers select it:
Symbol: PCMCIA_FDOMAIN [=m]
Type : tristate
Prompt: Future Domain PCMCIA support
Location:
-> Device Drivers
-> SCSI device support
-> PCMCIA SCSI adapter support (SCSI_LOWLEVEL_PCMCIA [=y])
Defined at drivers/scsi/pcmcia/Kconfig:22
Depends on: SCSI_LOWLEVEL_PCMCIA [=y] && SCSI [=y] && PCMCIA [=m] && m && MODULES [=y]
Selects: SCSI_FDOMAIN [=m]
Symbol: SCSI_FDOMAIN [=m]
Type : tristate
Defined at drivers/scsi/Kconfig:666
Depends on: SCSI_LOWLEVEL [=y] && SCSI [=y]
Selected by [m]:
- SCSI_FDOMAIN_PCI [=m] && SCSI_LOWLEVEL [=y] && PCI [=y] && SCSI [=y]
- SCSI_FDOMAIN_ISA [=m] && SCSI_LOWLEVEL [=y] && ISA [=y] && SCSI [=y]
- PCMCIA_FDOMAIN [=m] && SCSI_LOWLEVEL_PCMCIA [=y] && SCSI [=y] && PCMCIA [=m] && m && MODULES [=y]
Symbol: SCSI_FDOMAIN_ISA [=m]
Type : tristate
Prompt: Future Domain 16xx ISA SCSI support
Location:
-> Device Drivers
-> SCSI device support
-> SCSI low-level drivers (SCSI_LOWLEVEL [=y])
Defined at drivers/scsi/Kconfig:687
Depends on: SCSI_LOWLEVEL [=y] && ISA [=y] && SCSI [=y]
Selects: CHECK_SIGNATURE [=y] && SCSI_FDOMAIN [=m]
Symbol: SCSI_FDOMAIN_PCI [=m]
Type : tristate
Prompt: Future Domain TMC-3260/AHA-2920A PCI SCSI support
Location:
-> Device Drivers
-> SCSI device support
-> SCSI low-level drivers (SCSI_LOWLEVEL [=y])
Defined at drivers/scsi/Kconfig:670
Depends on: SCSI_LOWLEVEL [=y] && PCI [=y] && SCSI [=y]
Selects: SCSI_FDOMAIN [=m]
--
Ondrej Zary
prev parent reply other threads:[~2019-06-19 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 11:19 [PATCH] scsi: fdomain: fix building pcmcia front-end Arnd Bergmann
2019-06-19 3:13 ` Martin K. Petersen
2019-06-19 18:36 ` Ondrej Zary [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201906192036.37384.linux@zary.sk \
--to=linux@zary.sk \
--cc=arnd@arndb.de \
--cc=hare@suse.com \
--cc=jejb@linux.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).