From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yinbo Zhu <yinbo.zhu@nxp.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
xiaobo.xie@nxp.com, jiafei.pan@nxp.com,
Ramneek Mehresh <ramneek.mehresh@freescale.com>,
Nikhil Badola <nikhil.badola@freescale.com>,
Ran Wang <ran.wang_1@nxp.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 4/5] usb: host: Stops USB controller init if PLL fails to lock
Date: Thu, 20 Jun 2019 14:10:25 +0200 [thread overview]
Message-ID: <20190620121025.GB19295@kroah.com> (raw)
In-Reply-To: <20190614085433.22344-4-yinbo.zhu@nxp.com>
On Fri, Jun 14, 2019 at 04:54:32PM +0800, Yinbo Zhu wrote:
> From: Ramneek Mehresh <ramneek.mehresh@freescale.com>
>
> USB erratum-A006918 workaround tries to start internal PHY inside
> uboot (when PLL fails to lock). However, if the workaround also
> fails, then USB initialization is also stopped inside Linux.
> Erratum-A006918 workaround failure creates "fsl,erratum_a006918"
> node in device-tree. Presence of this node in device-tree is
> used to stop USB controller initialization in Linux
>
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> Signed-off-by: Suresh Gupta <suresh.gupta@freescale.com>
> Signed-off-by: Yinbo Zhu <yinbo.zhu@nxp.com>
> ---
> Change in v7:
> keep v5 version "fall through"
>
> drivers/usb/host/ehci-fsl.c | 9 +++++++++
> drivers/usb/host/fsl-mph-dr-of.c | 3 ++-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index 8f3bf3efb038..ef3dfd33a62e 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -236,6 +236,15 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
> portsc |= PORT_PTS_PTW;
> /* fall through */
> case FSL_USB2_PHY_UTMI:
> + /* Presence of this node "has_fsl_erratum_a006918"
> + * in device-tree is used to stop USB controller
> + * initialization in Linux
> + */
> + if (pdata->has_fsl_erratum_a006918) {
> + dev_warn(dev, "USB PHY clock invalid\n");
> + return -EINVAL;
> + }
> +
You need a /* fall through */ comment here, right?
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-20 12:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 8:54 [PATCH v7 1/5] usb: fsl: Set USB_EN bit to select ULPI phy Yinbo Zhu
2019-06-14 8:54 ` [PATCH v7 2/5] usb: phy: Workaround for USB erratum-A005728 Yinbo Zhu
2019-06-14 8:54 ` [PATCH v7 3/5] usb: linux/fsl_device: Add platform member has_fsl_erratum_a006918 Yinbo Zhu
2019-06-14 8:54 ` [PATCH v7 4/5] usb: host: Stops USB controller init if PLL fails to lock Yinbo Zhu
2019-06-20 12:10 ` Greg Kroah-Hartman [this message]
2019-06-24 4:05 ` [EXT] " Yinbo Zhu
2019-06-14 8:54 ` [PATCH v7 5/5] usb :fsl: Change string format for errata property Yinbo Zhu
2019-06-20 12:10 ` [PATCH v7 1/5] usb: fsl: Set USB_EN bit to select ULPI phy Greg Kroah-Hartman
2019-06-24 7:16 ` [EXT] " Yinbo Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620121025.GB19295@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jiafei.pan@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nikhil.badola@freescale.com \
--cc=ramneek.mehresh@freescale.com \
--cc=ran.wang_1@nxp.com \
--cc=stern@rowland.harvard.edu \
--cc=xiaobo.xie@nxp.com \
--cc=yinbo.zhu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).