linux-next: build warning after merge of the scsi tree

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 814 bytes --]

Hi all,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/pci-dma-compat.h:8,
                 from include/linux/pci.h:2408,
                 from drivers/scsi/mvumi.c:13:
drivers/scsi/mvumi.c: In function 'mvumi_queue_command':
include/linux/dma-mapping.h:608:34: warning: 'sg' may be used uninitialized in this function [-Wmaybe-uninitialized]
 #define dma_unmap_sg(d, s, n, r) dma_unmap_sg_attrs(d, s, n, r, 0)
                                  ^~~~~~~~~~~~~~~~~~
drivers/scsi/mvumi.c:192:22: note: 'sg' was declared here
  struct scatterlist *sg;
                      ^~

Introduced by commit

  350d66a72adc ("scsi: mvumi: use sg helper to iterate over scatterlist")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 469 bytes --]

Hi all,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/Makefile:197: FORCE prerequisite is missing

Exposed by commit

  0fc7db58e2a6 ("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and filechk")

I don't know why this warning only appeared after the merge of the scsi
tree, since the offending line has been in this Makefile since 2017

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi tree

[Masahiro Yamada]

On Fri, Aug 20, 2021 at 3:14 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/scsi/Makefile:197: FORCE prerequisite is missing
>
> Exposed by commit
>
>   0fc7db58e2a6 ("kbuild: warn if FORCE is missing for if_changed(_dep,_rule) and filechk")
>
> I don't know why this warning only appeared after the merge of the scsi
> tree, since the offending line has been in this Makefile since 2017

You are doing incremental builds.

Presumably, because include/scsi/scsi_devinfo.h
is touched by the following commit in the scsi tree.

commit f591a2e0548da88130c7b1c79f1f735273adc683
Author: Martin Kepplinger <martink@posteo.de>
Date:   Sun Jul 4 09:54:01 2021 +0200


Kbuild rebuilds scsi_devinfo_tbl.o due to the
timestamp update, then displays the warning.



If the scsi maintainers want to fix this issue,
a patch is already there.

https://lore.kernel.org/patchwork/patch/1478797/

Since this is a bug, it can get in the scsi tree
any time.





-- 
Best Regards
Masahiro Yamada

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Hi all,

After merging the scsi tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/driver-api/target:19: drivers/target/target_core_transport.c:1661: WARNING: Block quote ends without a blank line; unexpected unindent.

Introduced by commit

  750a1d93f905 ("scsi: target: core: Break up target_submit_cmd_map_sgls()")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 378 bytes --]

Hi all,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: modpost: missing MODULE_LICENSE() in drivers/scsi/ufs/ufs-exynos.o

Introduced by commit

  55f4b1f73631 ("scsi: ufs: ufs-exynos: Add UFS host support for Exynos SoCs")

(not sure why I missed this earlier, sorry)

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: build warning after merge of the scsi tree

[Alim Akhtar]

Hi Stephen

> -----Original Message-----
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Sent: 25 June 2020 09:11
> To: James Bottomley <James.Bottomley@HansenPartnership.com>
> Cc: Linux Next Mailing List <linux-next@vger.kernel.org>; Linux Kernel
Mailing
> List <linux-kernel@vger.kernel.org>; Alim Akhtar
<alim.akhtar@samsung.com>;
> Martin K. Petersen <martin.petersen@oracle.com>; Seungwon Jeon
> <essuuj@gmail.com>
> Subject: linux-next: build warning after merge of the scsi tree
> 
> Hi all,
> 
> After merging the scsi tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> WARNING: modpost: missing MODULE_LICENSE() in drivers/scsi/ufs/ufs-
> exynos.o
> 
Sorry about that, will send a fix patch soon.

> Introduced by commit
> 
>   55f4b1f73631 ("scsi: ufs: ufs-exynos: Add UFS host support for Exynos
SoCs")
> 
> (not sure why I missed this earlier, sorry)
> 
> --
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 509 bytes --]

Hi all,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_cpumask_of_node_init':
drivers/scsi/lpfc/lpfc_init.c:6020:6: warning: the address of 'cpu_all_bits' will always evaluate as 'true' [-Waddress]
 6020 |  if (!cpumask_of_node(numa_node))
      |      ^

Introduced by commit

  dcaa21367938 ("scsi: lpfc: Change default IRQ model on AMD architectures")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi tree

[Bart Van Assche]

On 11/6/19 8:01 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_cpumask_of_node_init':
> drivers/scsi/lpfc/lpfc_init.c:6020:6: warning: the address of 'cpu_all_bits' will always evaluate as 'true' [-Waddress]
>   6020 |  if (!cpumask_of_node(numa_node))
>        |      ^
> 
> Introduced by commit
> 
>    dcaa21367938 ("scsi: lpfc: Change default IRQ model on AMD architectures")

Thanks Stephen for this report. A candidate fix has been posted: 
https://lore.kernel.org/linux-scsi/20191107052158.25788-6-bvanassche@acm.org/T/#u

Bart.

Re: linux-next: build warning after merge of the scsi tree

[James Smart]

On 11/7/2019 7:51 AM, Bart Van Assche wrote:
> On 11/6/19 8:01 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the scsi tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced this warning:
>>
>> drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_cpumask_of_node_init':
>> drivers/scsi/lpfc/lpfc_init.c:6020:6: warning: the address of 
>> 'cpu_all_bits' will always evaluate as 'true' [-Waddress]
>>   6020 |  if (!cpumask_of_node(numa_node))
>>        |      ^
>>
>> Introduced by commit
>>
>>    dcaa21367938 ("scsi: lpfc: Change default IRQ model on AMD 
>> architectures")
> 
> Thanks Stephen for this report. A candidate fix has been posted: 
> https://lore.kernel.org/linux-scsi/20191107052158.25788-6-bvanassche@acm.org/T/#u 
> 
> 
> Bart.
> 
> 

See revised fix at:
https://marc.info/?l=linux-scsi&m=157325403920775&w=2

-- james

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 564 bytes --]

Hi all,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/ibmvscsi/ibmvscsi.c: In function 'ibmvscsi_work':
drivers/scsi/ibmvscsi/ibmvscsi.c:2151:5: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (rc) {
     ^
drivers/scsi/ibmvscsi/ibmvscsi.c:2121:6: note: 'rc' was declared here
  int rc;
      ^~

Introduced by commit

  035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi tree

[Tyrel Datwyler]

On 05/30/2019 08:36 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/ibmvscsi/ibmvscsi.c: In function 'ibmvscsi_work':
> drivers/scsi/ibmvscsi/ibmvscsi.c:2151:5: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   if (rc) {
>      ^
> drivers/scsi/ibmvscsi/ibmvscsi.c:2121:6: note: 'rc' was declared here
>   int rc;
>       ^~
> 
> Introduced by commit
> 
>   035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states")
> 

Oof, looks like I didn't compile with pedantic enough options, or just didn't
notice the warning. Declaration should be "int rc = 0;". I can send a follow on
patch.

-Tyrel

Re: linux-next: build warning after merge of the scsi tree

[Tyrel Datwyler]

On 05/30/2019 08:36 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/ibmvscsi/ibmvscsi.c: In function 'ibmvscsi_work':
> drivers/scsi/ibmvscsi/ibmvscsi.c:2151:5: warning: 'rc' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   if (rc) {
>      ^
> drivers/scsi/ibmvscsi/ibmvscsi.c:2121:6: note: 'rc' was declared here
>   int rc;
>       ^~
> 
> Introduced by commit
> 
>   035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action states")
> 

Looks like somebody else noticed the warning and a proposed fix was already sent
out.

-Tyrel

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 497 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_nvme.c:2140:1: warning: 'lpfc_nvme_lport_unreg_wait' defined but not used [-Wunused-function]
 lpfc_nvme_lport_unreg_wait(struct lpfc_vport *vport,
 ^~~~~~~~~~~~~~~~~~~~~~~~~~

Introduced by commit

  3999df75bccb ("scsi: lpfc: Declare local functions static")

It use is guarded by IS_ENABLED(CONFIG_NVME_FC).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi tree

[Bart Van Assche]

On 4/4/19 8:25 PM, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/lpfc/lpfc_nvme.c:2140:1: warning: 'lpfc_nvme_lport_unreg_wait' defined but not used [-Wunused-function]
>   lpfc_nvme_lport_unreg_wait(struct lpfc_vport *vport,
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Introduced by commit
> 
>    3999df75bccb ("scsi: lpfc: Declare local functions static")
> 
> It use is guarded by IS_ENABLED(CONFIG_NVME_FC).

I will have a closer look at this tomorrow.

Bart.

Re: linux-next: build warning after merge of the scsi tree

[James Bottomley]

On Thu, 2019-04-04 at 21:30 -0700, Bart Van Assche wrote:
> On 4/4/19 8:25 PM, Stephen Rothwell wrote:
> > Hi James,
> > 
> > After merging the scsi tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > drivers/scsi/lpfc/lpfc_nvme.c:2140:1: warning:
> > 'lpfc_nvme_lport_unreg_wait' defined but not used [-Wunused-
> > function]
> >   lpfc_nvme_lport_unreg_wait(struct lpfc_vport *vport,
> >   ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > Introduced by commit
> > 
> >    3999df75bccb ("scsi: lpfc: Declare local functions static")
> > 
> > It use is guarded by IS_ENABLED(CONFIG_NVME_FC).
> 
> I will have a closer look at this tomorrow.

In the meantime, we can just revert the patch.  Making functions static
serves no real purpose except it does tell the compiler they have to be
used internally which is where the problem is coming from.  Once the
issue is sorted, the static patch can be reapplied.

James

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 621 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_nodelist_open':
drivers/scsi/lpfc/lpfc_debugfs.c:706:17: warning: 'nrport' may be used uninitialized in this function [-Wmaybe-uninitialized]
   switch (nrport->port_state) {
           ~~~~~~^~~~~~~~~~~~
drivers/scsi/lpfc/lpfc_debugfs.c:553:30: note: 'nrport' was declared here
  struct nvme_fc_remote_port *nrport;
                              ^~~~~~

I am not sure where this has come from :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi tree

[James Bottomley]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

On Fri, 2018-10-19 at 15:50 +1100, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/lpfc/lpfc_debugfs.c: In function
> 'lpfc_debugfs_nodelist_open':
> drivers/scsi/lpfc/lpfc_debugfs.c:706:17: warning: 'nrport' may be
> used uninitialized in this function [-Wmaybe-uninitialized]
>    switch (nrport->port_state) {
>            ~~~~~~^~~~~~~~~~~~
> drivers/scsi/lpfc/lpfc_debugfs.c:553:30: note: 'nrport' was declared
> here
>   struct nvme_fc_remote_port *nrport;
>                               ^~~~~~
> 
> I am not sure where this has come from :-(

It's the merge commit ... it was obviously the wrong choice; I'll fix
it.

James

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 244 bytes --]

Hi James,

On Thu, 18 Oct 2018 21:54:03 -0700 James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
>
> It's the merge commit ... it was obviously the wrong choice; I'll fix
> it.

OK, thanks.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2490 bytes --]

Hi all,

On Wed, 20 Jun 2018 13:29:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the scsi tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> In file included from include/target/target_core_base.h:7:0,
>                  from drivers/target/target_core_tmr.c:31:
> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>                                               ^~~~~~~~
> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>                                                      ^~~~~~~~
> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>                                                            ^~~~~~~~
> In file included from include/target/target_core_base.h:7:0,
>                  from drivers/target/target_core_ua.c:30:
> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>                                               ^~~~~~~~
> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>                                                      ^~~~~~~~
> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>                                                            ^~~~~~~~
> 
> Introduced by commit
> 
>   24af1ccfe12a ("sbitmap: add helpers for dumping to a seq_file")
> 
> in v4.11.rc1, but exposed by commit
> 
>   eca7ee1f33e8 ("scsi: target: Convert target drivers to use sbitmap")

I am still seeing these warnings ...

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build warning after merge of the scsi tree

[Jens Axboe]

On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 20 Jun 2018 13:29:10 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>>
>> After merging the scsi tree, today's linux-next build (powerpc
>> allyesconfig) produced this warning:
>>
>> In file included from include/target/target_core_base.h:7:0,
>>                  from drivers/target/target_core_tmr.c:31:
>> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>>                                               ^~~~~~~~
>> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>>                                                      ^~~~~~~~
>> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>>                                                            ^~~~~~~~
>> In file included from include/target/target_core_base.h:7:0,
>>                  from drivers/target/target_core_ua.c:30:
>> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>>                                               ^~~~~~~~
>> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>>                                                      ^~~~~~~~
>> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>>                                                            ^~~~~~~~
>>
>> Introduced by commit
>>
>>   24af1ccfe12a ("sbitmap: add helpers for dumping to a seq_file")
>>
>> in v4.11.rc1, but exposed by commit
>>
>>   eca7ee1f33e8 ("scsi: target: Convert target drivers to use sbitmap")
> 
> I am still seeing these warnings ...

Martin queued up the forward declaration patch for this one, not sure
why it isn't showing up in the scsi tree yet.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the scsi tree

[James Bottomley]

On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
> On 7/10/18 1:31 AM, Stephen Rothwell wrote:
[...]
> > I am still seeing these warnings ...
> 
> Martin queued up the forward declaration patch for this one, not sure
> why it isn't showing up in the scsi tree yet.

All the trees are fully up to date ... which commit is it?

James

Re: linux-next: build warning after merge of the scsi tree

[Jens Axboe]

On 7/10/18 8:14 AM, James Bottomley wrote:
> On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
>> On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> [...]
>>> I am still seeing these warnings ...
>>
>> Martin queued up the forward declaration patch for this one, not sure
>> why it isn't showing up in the scsi tree yet.
> 
> All the trees are fully up to date ... which commit is it?

It's a patch from Arnd, I don't know what commit id it is. But
Martin replied a few days ago that it was applied. I don't have
the email handy, though.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the scsi tree

[James Bottomley]

On Tue, 2018-07-10 at 08:22 -0600, Jens Axboe wrote:
> On 7/10/18 8:14 AM, James Bottomley wrote:
> > On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
> > > On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> > 
> > [...]
> > > > I am still seeing these warnings ...
> > > 
> > > Martin queued up the forward declaration patch for this one, not
> > > sure
> > > why it isn't showing up in the scsi tree yet.
> > 
> > All the trees are fully up to date ... which commit is it?
> 
> It's a patch from Arnd, I don't know what commit id it is. But
> Martin replied a few days ago that it was applied. I don't have
> the email handy, though.

You mean

Message-Id:	<20180706201920.2185565-1-arnd@arndb.de>
Subject:	[PATCH] [v2] sbitmap, scsi/target: add seq_file forward declaration

?

Martin didn't reply and it's not yet in his tree, although I'm sure it
will be soon.

James

Re: linux-next: build warning after merge of the scsi tree

[Jens Axboe]

On 7/10/18 8:26 AM, James Bottomley wrote:
> On Tue, 2018-07-10 at 08:22 -0600, Jens Axboe wrote:
>> On 7/10/18 8:14 AM, James Bottomley wrote:
>>> On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
>>>> On 7/10/18 1:31 AM, Stephen Rothwell wrote:
>>>
>>> [...]
>>>>> I am still seeing these warnings ...
>>>>
>>>> Martin queued up the forward declaration patch for this one, not
>>>> sure
>>>> why it isn't showing up in the scsi tree yet.
>>>
>>> All the trees are fully up to date ... which commit is it?
>>
>> It's a patch from Arnd, I don't know what commit id it is. But
>> Martin replied a few days ago that it was applied. I don't have
>> the email handy, though.
> 
> You mean
> 
> Message-Id:	<20180706201920.2185565-1-arnd@arndb.de>
> Subject:	[PATCH] [v2] sbitmap, scsi/target: add seq_file forward declaration
> 
> ?
> 
> Martin didn't reply and it's not yet in his tree, although I'm sure it
> will be soon.

Yeah that's the one. I now had to look it up, looks like I mixed it up
with the host busy patch from Ming.

We should get it applied. Feel free to add my reviewed-by, if you want.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the scsi tree

[Martin K. Petersen]

Jens,

>> Message-Id:	<20180706201920.2185565-1-arnd@arndb.de>
>> Subject:	[PATCH] [v2] sbitmap, scsi/target: add seq_file forward declaration

>> Martin didn't reply and it's not yet in his tree, although I'm sure it
>> will be soon.

Been out on vacation. I thought I committed it but I guess not. I'll get
to it today.

-- 
Martin K. Petersen	Oracle Linux Engineering

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 468 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/storvsc_drv.c: In function 'storvsc_do_io':
drivers/scsi/storvsc_drv.c:1402:1: warning: the frame size of 2216 bytes is larger than 2048 bytes [-Wframe-larger-than=]
 }
 ^

Introduced by commit

  0b9bc24b8304 ("csi: storvsc: Select channel based on available percentage of ring buffer to write")

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: linux-next: build warning after merge of the scsi tree

[Long Li]

> Subject: linux-next: build warning after merge of the scsi tree
> 
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/scsi/storvsc_drv.c: In function 'storvsc_do_io':
> drivers/scsi/storvsc_drv.c:1402:1: warning: the frame size of 2216 bytes is
> larger than 2048 bytes [-Wframe-larger-than=]  }  ^
> 
> Introduced by commit
> 
>   0b9bc24b8304 ("csi: storvsc: Select channel based on available percentage of
> ring buffer to write")

Thanks for catching this. This is due to the size of struct cpumask is too big, when CONFIG_NR_CPUS=8192 is used in most kernel config.

I will fix this by moving those data structure to kmalloc pre-allocated when channel is first created.

> 
> --
> Cheers,
> Stephen Rothwell

Re: linux-next: build warning after merge of the scsi tree

[Martin K. Petersen]

Long,

> I will fix this by moving those data structure to kmalloc pre-allocated
> when channel is first created.

Sounds good. I'll drop patch 3 for now and wait for you to resubmit.

-- 
Martin K. Petersen	Oracle Linux Engineering

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/list.h:8:0,
                 from include/linux/module.h:9,
                 from drivers/scsi/sd.c:35:
drivers/scsi/sd.c: In function 'sd_revalidate_disk':
include/linux/kernel.h:755:16: warning: comparison of distinct pointer types lacks a cast
  (void) (&min1 == &min2);   \
                ^
include/linux/kernel.h:758:2: note: in expansion of macro '__min'
  __min(typeof(x), typeof(y),   \
  ^
include/linux/kernel.h:783:39: note: in expansion of macro 'min'
  __x == 0 ? __y : ((__y == 0) ? __x : min(__x, __y)); })
                                       ^
drivers/scsi/sd.c:2959:12: note: in expansion of macro 'min_not_zero'
   rw_max = min_not_zero(logical_to_sectors(sdp, dev_max),
            ^

Introduced by commit

  c3e62673ee20 ("scsi: sd: Consider max_xfer_blocks if opt_xfer_blocks is unusable")

logical_to_sectors() is a sector_t and BLK_DEF_MAX_SECTORS is an "enum
blk_default_limits" (i.e. int).

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the scsi tree

[Fam Zheng]

On Thu, 04/06 14:04, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> In file included from include/linux/list.h:8:0,
>                  from include/linux/module.h:9,
>                  from drivers/scsi/sd.c:35:
> drivers/scsi/sd.c: In function 'sd_revalidate_disk':
> include/linux/kernel.h:755:16: warning: comparison of distinct pointer types lacks a cast
>   (void) (&min1 == &min2);   \
>                 ^
> include/linux/kernel.h:758:2: note: in expansion of macro '__min'
>   __min(typeof(x), typeof(y),   \
>   ^
> include/linux/kernel.h:783:39: note: in expansion of macro 'min'
>   __x == 0 ? __y : ((__y == 0) ? __x : min(__x, __y)); })
>                                        ^
> drivers/scsi/sd.c:2959:12: note: in expansion of macro 'min_not_zero'
>    rw_max = min_not_zero(logical_to_sectors(sdp, dev_max),
>             ^
> 
> Introduced by commit
> 
>   c3e62673ee20 ("scsi: sd: Consider max_xfer_blocks if opt_xfer_blocks is unusable")
> 
> logical_to_sectors() is a sector_t and BLK_DEF_MAX_SECTORS is an "enum
> blk_default_limits" (i.e. int).

Hi Stephen, James,

I will send a patch to fix this warning.

Fam

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
drivers/scsi/hpsa.c:2033:5: warning: 'sd' may be used uninitialized in this function [-Wmaybe-uninitialized]
  if (!sd)
     ^

Introduced by commit

  4eb307f7b18d ("scsi: hpsa: use bus '3' for legacy HBA devices")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the scsi tree

[Martin K. Petersen]

>>>>> "Stephen" == Stephen Rothwell <sfr@canb.auug.org.au> writes:

Stephen,

Stephen> drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
Stephen> drivers/scsi/hpsa.c:2033:5: warning: 'sd' may be used
Stephen> uninitialized in this function [-Wmaybe-uninitialized]
Stephen>   if (!sd)
Stephen>      ^

Stephen> Introduced by commit

Stephen>   4eb307f7b18d ("scsi: hpsa: use bus '3' for legacy HBA
Stephen>   devices")

Fixed this up.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma':
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20: warning: unused variable 'srp' [-Wunused-variable]
    struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf;
                    ^

Introduced by commit

  812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the scsi tree

[Bryant G. Ly]

On 9/12/16, 11:15 PM, "Stephen Rothwell" <sfr@canb.auug.org.au> wrote:

    > Hi James,
    > 
    > After merging the scsi tree, today's linux-next build (powerpc
    > allyesconfig) produced this warning:
    > 
    > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma':
    > drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20: warning: unused variable 'srp' [-Wunused-variable]
    >     struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf;
    >                     ^
    > 
    > Introduced by commit
    > 
     >  812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")
    
Looks like cleaning up the print statement made this variable unused so deleting that line would be best. 

-Bryant     
    

Re: linux-next: build warning after merge of the scsi tree

[Martin K. Petersen]

>>>>> "Bryant" == Bryant G Ly <bryantly@linux.vnet.ibm.com> writes:

Bryant> On 9/12/16, 11:15 PM, "Stephen Rothwell" <sfr@canb.auug.org.au> wrote:

>> Hi James,
>> 
>> After merging the scsi tree, today's linux-next build (powerpc
>> allyesconfig) produced this warning:
>> 
>> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function
>> 'ibmvscsis_rdma': drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20:
>> warning: unused variable 'srp' [-Wunused-variable] struct srp_cmd
>> *srp = (struct srp_cmd *)iue->sbuf->buf; ^
>> 
>> Introduced by commit
>> 
>> 812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")
    
Bryant> Looks like cleaning up the print statement made this variable
Bryant> unused so deleting that line would be best.

Please submit a patch to do so.

-- 
Martin K. Petersen	Oracle Linux Engineering

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 460 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_queuecommand_lck':
drivers/scsi/ibmvscsi/ibmvfc.c:1618:5: warning: unused variable 'tag' [-Wunused-variable]
  u8 tag[2];
     ^

Introduced by commit 5066863337af ("scsi: remove abuses of
scsi_populate_tag").

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: linux-next: build warning after merge of the scsi tree

[Christoph Hellwig]

On Tue, Nov 18, 2014 at 07:21:48PM +1100, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_queuecommand_lck':
> drivers/scsi/ibmvscsi/ibmvfc.c:1618:5: warning: unused variable 'tag' [-Wunused-variable]
>   u8 tag[2];

Thanks Stephen, I'll take care of fixing this up.

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 685 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler':
drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is deprecated (declared at /scratch/sfr/next/include/linux/workqueue.h:624) [-Wdeprecated-declarations]
   flush_work_sync(&hba->eh_work);
   ^

Introduced by commit c1e846ab4422 ("[SCSI] ufs: Fix device and host reset
methods").  flush_work_sync was deprecated by commit 43829731dd37
("workqueue: deprecate flush[_delayed]_work_sync()") before v3.7-rc1.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

Re: linux-next: build warning after merge of the scsi tree

[Sujit Reddy Thumma]

On 9/2/2013 1:58 PM, Stephen Rothwell wrote:
> Hi James,
>
> After merging the scsi tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler':
> drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is deprecated (declared at /scratch/sfr/next/include/linux/workqueue.h:624) [-Wdeprecated-declarations]
>     flush_work_sync(&hba->eh_work);
>     ^

James, would you like to pick up follow-up patch @
http://marc.info/?l=linux-scsi&m=137819519527432&w=2
or let me update the commit c1e846ab4422 fixing this?

>
> Introduced by commit c1e846ab4422 ("[SCSI] ufs: Fix device and host reset
> methods").  flush_work_sync was deprecated by commit 43829731dd37
> ("workqueue: deprecate flush[_delayed]_work_sync()") before v3.7-rc1.
>

-- 
Regards,
Sujit

Re: linux-next: build warning after merge of the scsi tree

[Sujit Reddy Thumma]

On 9/4/2013 2:48 PM, Sujit Reddy Thumma wrote:
> On 9/2/2013 1:58 PM, Stephen Rothwell wrote:
>> Hi James,
>>
>> After merging the scsi tree, today's linux-next build (x86_64
>> allmodconfig) produced this warning:
>>
>> drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler':
>> drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is
>> deprecated (declared at
>> /scratch/sfr/next/include/linux/workqueue.h:624)
>> [-Wdeprecated-declarations]
>>     flush_work_sync(&hba->eh_work);
>>     ^
>
> James, would you like to pick up follow-up patch @
> http://marc.info/?l=linux-scsi&m=137819519527432&w=2
> or let me update the commit c1e846ab4422 fixing this?

Ignore this.
I saw you have dropped the patchset already. I will fix and post the
updated patches soon. Thanks.

>
>>
>> Introduced by commit c1e846ab4422 ("[SCSI] ufs: Fix device and host reset
>> methods").  flush_work_sync was deprecated by commit 43829731dd37
>> ("workqueue: deprecate flush[_delayed]_work_sync()") before v3.7-rc1.
>>
>

-- 
Regards,
Sujit

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 515 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/mpt2sas/mpt2sas_scsih.c: In function '_scsih_sas_broadcast_primative_event':
drivers/scsi/mpt2sas/mpt2sas_scsih.c:5591:40: warning: unused variable 'event_data'

Probably introduced by commit f93213de5c28 ("[SCSI] mpt2sas: fix
broadcast AEN and task management issue").
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the scsi tree

[Nicholas A. Bellinger]

On Wed, 2011-05-18 at 11:49 +1000, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (x86_64 allmodconfig)
> produced this warning:
> 
> drivers/target/tcm_fc/tfc_io.c: In function 'ft_queue_data_in':
> drivers/target/tcm_fc/tfc_io.c:209: warning: format '%x' expects type 'unsigned int', but argument 5 has type 'size_t'
> 
> Introduced by commit 3699d92a4d7b ("[SCSI] tcm_fc: Adding FC_FC4 provider
> (tcm_fc) for FCoE target (TCM - target core) support").
> 

Hi Stephen,

It appears that this warning was fixed in LIO upstream a while back, but
did not make it into this morning scsi-misc merge.  Please apply.

Thanks!

--nab


>From b830de5068d0c3745e83393f81d87f745ef7a4f2 Mon Sep 17 00:00:00 2001
From: Nicholas Bellinger <nab@linux-iscsi.org>
Date: Thu, 17 Feb 2011 21:56:16 +0000
Subject: [PATCH] tcm_fc: Fix conversion spec compile warning in ft_queue_data_in
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This patch fixes the following compile warning in ft_queue_data_in():

drivers/target/tcm_fc/tfc_io.c: In function ‘ft_queue_data_in’:
drivers/target/tcm_fc/tfc_io.c:209: warning: format ‘%x’ expects type ‘unsigned int’, but argument 5 has type ‘size_t’

Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
---
 drivers/target/tcm_fc/tfc_io.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c
index 4c3c0ef..3936bb1 100644
--- a/drivers/target/tcm_fc/tfc_io.c
+++ b/drivers/target/tcm_fc/tfc_io.c
@@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
                                                "xid <0x%x>, remaining <0x%x>, "
                                                "lso_max <0x%x>\n",
                                                __func__, fp, ep->xid,
-                                               remaining, lport->lso_max);
+                                               (unsigned int)remaining,
+                                               lport->lso_max);
                }
        }
        return ft_queue_status(se_cmd);
-- 
1.7.5.1

Re: linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 2557 bytes --]

Hi Nicholas,

On Tue, 17 May 2011 19:06:02 -0700 "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote:
>
> On Wed, 2011-05-18 at 11:49 +1000, Stephen Rothwell wrote:
> > 
> > After merging the scsi tree, today's linux-next build (x86_64 allmodconfig)
> > produced this warning:
> > 
> > drivers/target/tcm_fc/tfc_io.c: In function 'ft_queue_data_in':
> > drivers/target/tcm_fc/tfc_io.c:209: warning: format '%x' expects type 'unsigned int', but argument 5 has type 'size_t'
> > 
> > Introduced by commit 3699d92a4d7b ("[SCSI] tcm_fc: Adding FC_FC4 provider
> > (tcm_fc) for FCoE target (TCM - target core) support").
> > 
> 
> It appears that this warning was fixed in LIO upstream a while back, but
> did not make it into this morning scsi-misc merge.  Please apply.
> 
> >From b830de5068d0c3745e83393f81d87f745ef7a4f2 Mon Sep 17 00:00:00 2001
> From: Nicholas Bellinger <nab@linux-iscsi.org>
> Date: Thu, 17 Feb 2011 21:56:16 +0000
> Subject: [PATCH] tcm_fc: Fix conversion spec compile warning in ft_queue_data_in
> MIME-Version: 1.0
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 8bit
> 
> This patch fixes the following compile warning in ft_queue_data_in():
> 
> drivers/target/tcm_fc/tfc_io.c: In function ‘ft_queue_data_in’:
> drivers/target/tcm_fc/tfc_io.c:209: warning: format ‘%x’ expects type ‘unsigned int’, but argument 5 has type ‘size_t’
> 
> Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
> ---
>  drivers/target/tcm_fc/tfc_io.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c
> index 4c3c0ef..3936bb1 100644
> --- a/drivers/target/tcm_fc/tfc_io.c
> +++ b/drivers/target/tcm_fc/tfc_io.c
> @@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
>                                                 "xid <0x%x>, remaining <0x%x>, "
>                                                 "lso_max <0x%x>\n",
>                                                 __func__, fp, ep->xid,
> -                                               remaining, lport->lso_max);
> +                                               (unsigned int)remaining,
> +                                               lport->lso_max);

Given that "remaining" really is a length, surely it makes more sense to
print it with %zd than to cast it and print it with %x ...

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the scsi tree

[Nicholas A. Bellinger]

On Wed, 2011-05-18 at 13:58 +1000, Stephen Rothwell wrote:
> Hi Nicholas,
> 
> On Tue, 17 May 2011 19:06:02 -0700 "Nicholas A. Bellinger" <nab@linux-iscsi.org> wrote:
> >
> > On Wed, 2011-05-18 at 11:49 +1000, Stephen Rothwell wrote:
> > > 
> > > After merging the scsi tree, today's linux-next build (x86_64 allmodconfig)
> > > produced this warning:
> > > 
> > > drivers/target/tcm_fc/tfc_io.c: In function 'ft_queue_data_in':
> > > drivers/target/tcm_fc/tfc_io.c:209: warning: format '%x' expects type 'unsigned int', but argument 5 has type 'size_t'
> > > 
> > > Introduced by commit 3699d92a4d7b ("[SCSI] tcm_fc: Adding FC_FC4 provider
> > > (tcm_fc) for FCoE target (TCM - target core) support").
> > > 
> > 
> > It appears that this warning was fixed in LIO upstream a while back, but
> > did not make it into this morning scsi-misc merge.  Please apply.
> > 
> > >From b830de5068d0c3745e83393f81d87f745ef7a4f2 Mon Sep 17 00:00:00 2001
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> > Date: Thu, 17 Feb 2011 21:56:16 +0000
> > Subject: [PATCH] tcm_fc: Fix conversion spec compile warning in ft_queue_data_in
> > MIME-Version: 1.0
> > Content-Type: text/plain; charset=UTF-8
> > Content-Transfer-Encoding: 8bit
> > 
> > This patch fixes the following compile warning in ft_queue_data_in():
> > 
> > drivers/target/tcm_fc/tfc_io.c: In function ‘ft_queue_data_in’:
> > drivers/target/tcm_fc/tfc_io.c:209: warning: format ‘%x’ expects type ‘unsigned int’, but argument 5 has type ‘size_t’
> > 
> > Signed-off-by: Nicholas A. Bellinger <nab@linux-iscsi.org>
> > ---
> >  drivers/target/tcm_fc/tfc_io.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c
> > index 4c3c0ef..3936bb1 100644
> > --- a/drivers/target/tcm_fc/tfc_io.c
> > +++ b/drivers/target/tcm_fc/tfc_io.c
> > @@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
> >                                                 "xid <0x%x>, remaining <0x%x>, "
> >                                                 "lso_max <0x%x>\n",
> >                                                 __func__, fp, ep->xid,
> > -                                               remaining, lport->lso_max);
> > +                                               (unsigned int)remaining,
> > +                                               lport->lso_max);
> 
> Given that "remaining" really is a length, surely it makes more sense to
> print it with %zd than to cast it and print it with %x ...
> 

This is fine with me.  Bad habit of explictly casting conversion
specifications from sector_t type usage..

Kiran, would you mind fixing this to use %zd in your tree, and include
this along with the TMR LUN_RESET bugfix for James to include in
scsi-misc..?

Thanks,

--nab

Re: linux-next: build warning after merge of the scsi tree

[Kiran Patil]

Hi All,

Sorry, I should have fixed that issue. Anyways, I will fix it and send 
patch out.


On 5/18/2011 7:54 PM, Nicholas A. Bellinger wrote:
> On Wed, 2011-05-18 at 13:58 +1000, Stephen Rothwell wrote:
>> Hi Nicholas,
>>
>> On Tue, 17 May 2011 19:06:02 -0700 "Nicholas A. Bellinger"<nab@linux-iscsi.org>  wrote:
>>> On Wed, 2011-05-18 at 11:49 +1000, Stephen Rothwell wrote:
>>>> After merging the scsi tree, today's linux-next build (x86_64 allmodconfig)
>>>> produced this warning:
>>>>
>>>> drivers/target/tcm_fc/tfc_io.c: In function 'ft_queue_data_in':
>>>> drivers/target/tcm_fc/tfc_io.c:209: warning: format '%x' expects type 'unsigned int', but argument 5 has type 'size_t'
>>>>
>>>> Introduced by commit 3699d92a4d7b ("[SCSI] tcm_fc: Adding FC_FC4 provider
>>>> (tcm_fc) for FCoE target (TCM - target core) support").
>>>>
>>> It appears that this warning was fixed in LIO upstream a while back, but
>>> did not make it into this morning scsi-misc merge.  Please apply.
>>>
>>> > From b830de5068d0c3745e83393f81d87f745ef7a4f2 Mon Sep 17 00:00:00 2001
>>> From: Nicholas Bellinger<nab@linux-iscsi.org>
>>> Date: Thu, 17 Feb 2011 21:56:16 +0000
>>> Subject: [PATCH] tcm_fc: Fix conversion spec compile warning in ft_queue_data_in
>>> MIME-Version: 1.0
>>> Content-Type: text/plain; charset=UTF-8
>>> Content-Transfer-Encoding: 8bit
>>>
>>> This patch fixes the following compile warning in ft_queue_data_in():
>>>
>>> drivers/target/tcm_fc/tfc_io.c: In function ‘ft_queue_data_in’:
>>> drivers/target/tcm_fc/tfc_io.c:209: warning: format ‘%x’ expects type ‘unsigned int’, but argument 5 has type ‘size_t’
>>>
>>> Signed-off-by: Nicholas A. Bellinger<nab@linux-iscsi.org>
>>> ---
>>>   drivers/target/tcm_fc/tfc_io.c |    3 ++-
>>>   1 files changed, 2 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/target/tcm_fc/tfc_io.c b/drivers/target/tcm_fc/tfc_io.c
>>> index 4c3c0ef..3936bb1 100644
>>> --- a/drivers/target/tcm_fc/tfc_io.c
>>> +++ b/drivers/target/tcm_fc/tfc_io.c
>>> @@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
>>>                                                  "xid<0x%x>, remaining<0x%x>, "
>>>                                                  "lso_max<0x%x>\n",
>>>                                                  __func__, fp, ep->xid,
>>> -                                               remaining, lport->lso_max);
>>> +                                               (unsigned int)remaining,
>>> +                                               lport->lso_max);
>> Given that "remaining" really is a length, surely it makes more sense to
>> print it with %zd than to cast it and print it with %x ...
>>
> This is fine with me.  Bad habit of explictly casting conversion
> specifications from sector_t type usage..
>
> Kiran, would you mind fixing this to use %zd in your tree, and include
> this along with the TMR LUN_RESET bugfix for James to include in
> scsi-misc..?
>
> Thanks,
>
> --nab
>
No problem. I will fix it and get it out along with my other patch 
series for offload, big fixes, etc.. via. Open-FCoE which has been 
rebased to scsi-misc yesterday (scsi-misc now has tcm_fc)

Thanks,
-- Kiran P.

Re: linux-next: build warning after merge of the scsi tree

[Geert Uytterhoeven]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1588 bytes --]

On Wed, May 18, 2011 at 05:58, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>> --- a/drivers/target/tcm_fc/tfc_io.c
>> +++ b/drivers/target/tcm_fc/tfc_io.c
>> @@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
>>                                                 "xid <0x%x>, remaining <0x%x>, "
>>                                                 "lso_max <0x%x>\n",
>>                                                 __func__, fp, ep->xid,
>> -                                               remaining, lport->lso_max);
>> +                                               (unsigned int)remaining,
>> +                                               lport->lso_max);
>
> Given that "remaining" really is a length, surely it makes more sense to

Exactly my comments ...

> print it with %zd than to cast it and print it with %x ...

... except that size_t is unsigned, so %zu would be a little bit better.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: linux-next: build warning after merge of the scsi tree

[Randy Dunlap]

On Thu, 19 May 2011 18:22:59 +0200 Geert Uytterhoeven wrote:

> On Wed, May 18, 2011 at 05:58, Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >> --- a/drivers/target/tcm_fc/tfc_io.c
> >> +++ b/drivers/target/tcm_fc/tfc_io.c
> >> @@ -206,7 +206,8 @@ int ft_queue_data_in(struct se_cmd *se_cmd)
> >>                                                 "xid <0x%x>, remaining <0x%x>, "
> >>                                                 "lso_max <0x%x>\n",
> >>                                                 __func__, fp, ep->xid,
> >> -                                               remaining, lport->lso_max);
> >> +                                               (unsigned int)remaining,
> >> +                                               lport->lso_max);
> >
> > Given that "remaining" really is a length, surely it makes more sense to
> 
> Exactly my comments ...
> 
> > print it with %zd than to cast it and print it with %x ...
> 
> ... except that size_t is unsigned, so %zu would be a little bit better.


This still needs to be fixed in linux-next (20110623).

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 457 bytes --]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/scsi_sysfs.c:384: warning: dereferencing 'void *' pointer

Introduced by commit db5bd1e0b505c54ff492172ce4abc245cf6cd639 ("[SCSI]
convert to the new PM framework").  This build does not have
CONFIG_PM_OPS set.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

Re: linux-next: build warning after merge of the scsi tree

[James Bottomley]

cc linux-scsi added

On Wed, 2010-08-04 at 13:13 +1000, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/scsi_sysfs.c:384: warning: dereferencing 'void *' pointer
> 
> Introduced by commit db5bd1e0b505c54ff492172ce4abc245cf6cd639 ("[SCSI]
> convert to the new PM framework").  This build does not have
> CONFIG_PM_OPS set.

So this one looks to be a compiler error.  in the none CONFIG_PM_OPS
case, we have

scsi_priv.h:#define scsi_bus_pm_ops             (*NULL)

So &scsi_bus_pm_ops should be NULL (not a deref of null).

James

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1217 bytes --]

Hi all,

After merging the percpu tree, today's linux-next build (powerpc
ppc64_defconfig) produced these warnings:

drivers/scsi/qla2xxx/qla_attr.c: In function 'qla2x00_process_vendor_specific':
drivers/scsi/qla2xxx/qla_attr.c:2150: warning: 'req_data' may be used uninitialized in this function
drivers/scsi/qla2xxx/qla_attr.c:2152: warning: 'req_data_len' may be used uninitialized in this function

If the first "goto done_unmap_sg;" in this function is followed, the
req_data will be tested even though it has not been assigned to yet and
if it is non zero, it and req_data_len will be passed to
dma_free_coherent() while still uninitialised.

Introduced by commit 9a069e196767d7b87184fd8d8211d22bb5b9c0b8 ("[SCSI]
qla2xxx: Add BSG support for FC ELS/CT passthrough and vendor commands").

The compiler also produces these:

drivers/scsi/qla2xxx/qla_attr.c:2144: warning: 'command_sent' may be used uninitialized in this function
drivers/scsi/qla2xxx/qla_attr.c:2146: warning: 'type' may be used uninitialized in this function

but I can't easily tell if they are false positives.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: linux-next: build warning after merge of the scsi tree

[James Bottomley]

On Wed, 2010-02-10 at 16:51 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the percpu tree, today's linux-next build (powerpc
> ppc64_defconfig) produced these warnings:
> 
> drivers/scsi/qla2xxx/qla_attr.c: In function 'qla2x00_process_vendor_specific':
> drivers/scsi/qla2xxx/qla_attr.c:2150: warning: 'req_data' may be used uninitialized in this function
> drivers/scsi/qla2xxx/qla_attr.c:2152: warning: 'req_data_len' may be used uninitialized in this function
> 
> If the first "goto done_unmap_sg;" in this function is followed, the
> req_data will be tested even though it has not been assigned to yet and
> if it is non zero, it and req_data_len will be passed to
> dma_free_coherent() while still uninitialised.
> 
> Introduced by commit 9a069e196767d7b87184fd8d8211d22bb5b9c0b8 ("[SCSI]
> qla2xxx: Add BSG support for FC ELS/CT passthrough and vendor commands").
> 
> The compiler also produces these:
> 
> drivers/scsi/qla2xxx/qla_attr.c:2144: warning: 'command_sent' may be used uninitialized in this function
> drivers/scsi/qla2xxx/qla_attr.c:2146: warning: 'type' may be used uninitialized in this function
> 
> but I can't easily tell if they are false positives.

They seem to be false positives.  The unconditional initialisation is on
line 2191, and there's no use before then that I can find ... I also
don't see this error on my builds, so it looks like a toolchain issue.

James