From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 081C8C43613 for ; Mon, 24 Jun 2019 10:06:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C6885208E3 for ; Mon, 24 Jun 2019 10:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561370778; bh=2Oz6+lcMk60ggBjHIz3gvLIYXQiQ1JfdMB6XD2gj2Z0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=h8y2ysONsuPW/QCfR1dXxXnZsGtrpNwor/lz6YNRl3oTDo3RJjqE/CJeff2Go0h/o BLFFV0ggvxCfB5aUoggXX4l+QQfP7SXgCKusjoliISfsQSdYfJWDexPOi256fHDmMY 5+ElKtBWtBl76wcqUt/9SfZZZQYQNGZNOGbFIvZM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730069AbfFXKGR (ORCPT ); Mon, 24 Jun 2019 06:06:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:38344 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729489AbfFXKGO (ORCPT ); Mon, 24 Jun 2019 06:06:14 -0400 Received: from localhost (f4.8f.5177.ip4.static.sl-reverse.com [119.81.143.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A1767212F5; Mon, 24 Jun 2019 10:06:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561370774; bh=2Oz6+lcMk60ggBjHIz3gvLIYXQiQ1JfdMB6XD2gj2Z0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AuJBAhsQp20jJ+6lSSMqxjM8u3P/yRV1S1XioiDwUElvJuQyyaKmrP2LSZPgT2DZ2 23+s1sC6EDWf0WR/8r+MUU8LQOixKf85/XG61uhGTebHEKu8g7KUe+ACEZqxDQtJXz y12+B+GEohxYaXDBqskQ74dbe5SCLQrmyD8zWiys= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gen Zhang , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 51/90] mdesc: fix a missing-check bug in get_vdev_port_node_info() Date: Mon, 24 Jun 2019 17:56:41 +0800 Message-Id: <20190624092317.544998019@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190624092313.788773607@linuxfoundation.org> References: <20190624092313.788773607@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 80caf43549e7e41a695c6d1e11066286538b336f ] In get_vdev_port_node_info(), 'node_info->vdev_port.name' is allcoated by kstrdup_const(), and it returns NULL when fails. So 'node_info->vdev_port.name' should be checked. Signed-off-by: Gen Zhang Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- arch/sparc/kernel/mdesc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/sparc/kernel/mdesc.c b/arch/sparc/kernel/mdesc.c index 39a2503fa3e1..51028abe5e90 100644 --- a/arch/sparc/kernel/mdesc.c +++ b/arch/sparc/kernel/mdesc.c @@ -357,6 +357,8 @@ static int get_vdev_port_node_info(struct mdesc_handle *md, u64 node, node_info->vdev_port.id = *idp; node_info->vdev_port.name = kstrdup_const(name, GFP_KERNEL); + if (!node_info->vdev_port.name) + return -1; node_info->vdev_port.parent_cfg_hdl = *parent_cfg_hdlp; return 0; -- 2.20.1