From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95B47C43613 for ; Mon, 24 Jun 2019 10:09:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64DD521473 for ; Mon, 24 Jun 2019 10:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561370981; bh=FqfyOE32pGG0nTN2uey/6HiKT1i752OzCJIa1JzZZJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=u9huVAf2pdwmlNp2UoHgNBw3fm1wSRefxFpFTv89QDWo5GJjdDfJofSn5vkO4+bQ9 9qutNPoEQprRCGIuE7siKf6QRTEJ7IWdzUvp41Eq+ct/VuBRhqKD+RONoKZWx2hbnl TJneDOTPISMhGre3Pz0Nj4MhjBs/y+8WmdtqEfZo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730316AbfFXKJk (ORCPT ); Mon, 24 Jun 2019 06:09:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:42536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730489AbfFXKIm (ORCPT ); Mon, 24 Jun 2019 06:08:42 -0400 Received: from localhost (f4.8f.5177.ip4.static.sl-reverse.com [119.81.143.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0782A2089F; Mon, 24 Jun 2019 10:08:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561370921; bh=FqfyOE32pGG0nTN2uey/6HiKT1i752OzCJIa1JzZZJM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PusuoNYsjL9oKhXYSb6hJc1r05w6hbCDX/wbezzDLoK0FBy/iC1vXDL8i9kSQOa/A U8VCyQcfHoAkQpY9nWlrOfEaWpGCXarBXu5PHZaZNkkcqGR20O4R3dhaatiT5FF2x2 +4OnWwrXHr7pgZ43ecdRfedSzgiklIQX1PUdMoVE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Michael J. Ruhl" , Dennis Dalessandro , Mike Marciniszyn , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.1 051/121] IB/hfi1: Insure freeze_work work_struct is canceled on shutdown Date: Mon, 24 Jun 2019 17:56:23 +0800 Message-Id: <20190624092323.346979705@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190624092320.652599624@linuxfoundation.org> References: <20190624092320.652599624@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 6d517353c70bb0818b691ca003afdcb5ee5ea44e ] By code inspection, the freeze_work is never canceled. Fix by adding a cancel_work_sync in the shutdown path to insure it is no longer running. Fixes: 7724105686e7 ("IB/hfi1: add driver files") Reviewed-by: Michael J. Ruhl Reviewed-by: Dennis Dalessandro Signed-off-by: Mike Marciniszyn Signed-off-by: Dennis Dalessandro Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/hfi1/chip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/hfi1/chip.c b/drivers/infiniband/hw/hfi1/chip.c index e02d9a739e9c..597f2f02f3a8 100644 --- a/drivers/infiniband/hw/hfi1/chip.c +++ b/drivers/infiniband/hw/hfi1/chip.c @@ -9848,6 +9848,7 @@ void hfi1_quiet_serdes(struct hfi1_pportdata *ppd) /* disable the port */ clear_rcvctrl(dd, RCV_CTRL_RCV_PORT_ENABLE_SMASK); + cancel_work_sync(&ppd->freeze_work); } static inline int init_cpu_counters(struct hfi1_devdata *dd) -- 2.20.1