From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH v2 06/15] dt-bindings: display: Convert dlc,dlc0700yzg-1 panel to DT schema
Date: Tue, 25 Jun 2019 09:55:42 +0200 [thread overview]
Message-ID: <20190625075542.u5kzex4cbrcss5ga@flea> (raw)
In-Reply-To: <20190624215649.8939-7-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 2871 bytes --]
Hi,
On Mon, Jun 24, 2019 at 03:56:40PM -0600, Rob Herring wrote:
> Convert the dlc,dlc0700yzg-1 panel binding to DT schema.
>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../display/panel/dlc,dlc0700yzg-1.txt | 13 ---------
> .../display/panel/dlc,dlc0700yzg-1.yaml | 28 +++++++++++++++++++
> 2 files changed, 28 insertions(+), 13 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt
> create mode 100644 Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt b/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt
> deleted file mode 100644
> index bf06bb025b08..000000000000
> --- a/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.txt
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -DLC Display Co. DLC0700YZG-1 7.0" WSVGA TFT LCD panel
> -
> -Required properties:
> -- compatible: should be "dlc,dlc0700yzg-1"
> -- power-supply: See simple-panel.txt
> -
> -Optional properties:
> -- reset-gpios: See panel-common.txt
> -- enable-gpios: See simple-panel.txt
> -- backlight: See simple-panel.txt
> -
> -This binding is compatible with the simple-panel binding, which is specified
> -in simple-panel.txt in this directory.
> diff --git a/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml b/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml
> new file mode 100644
> index 000000000000..1b0b63d46f3e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/dlc,dlc0700yzg-1.yaml
> @@ -0,0 +1,28 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/dlc,dlc0700yzg-1.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: DLC Display Co. DLC0700YZG-1 7.0" WSVGA TFT LCD panel
> +
> +maintainers:
> + - Philipp Zabel <p.zabel@pengutronix.de>
> + - Thierry Reding <thierry.reding@gmail.com>
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: dlc,dlc0700yzg-1
> +
> + reset-gpios: true
> + enable-gpios: true
> + backlight: true
Do we need to list them?
Since we don't have additionalItems, it doesn't really change anything
since it will be validated by panel-common.
Either way, it should be consistent between your patches, and the
previous patches in this series didn't list all the properties in the
binding.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2019-06-25 7:55 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 21:56 [PATCH v2 00/15] Conversion of panel bindings to DT schema Rob Herring
2019-06-24 21:56 ` [PATCH v2 01/15] dt-bindings: display: rockchip-lvds: Remove panel references Rob Herring
2019-06-27 8:37 ` Heiko Stuebner
2019-06-24 21:56 ` [PATCH v2 02/15] dt-bindings: display: Convert common panel bindings to DT schema Rob Herring
2019-06-24 21:56 ` [PATCH v2 03/15] dt-bindings: display: Convert ampire,am-480272h3tmqw-t01h panel " Rob Herring
2019-06-24 21:56 ` [PATCH v2 04/15] dt-bindings: display: Convert armadeus,st0700-adapt " Rob Herring
2019-06-25 7:51 ` Maxime Ripard
2019-06-24 21:56 ` [PATCH v2 05/15] dt-bindings: display: Convert bananapi,s070wv20-ct16 " Rob Herring
2019-06-25 7:54 ` Maxime Ripard
2019-06-24 21:56 ` [PATCH v2 06/15] dt-bindings: display: Convert dlc,dlc0700yzg-1 " Rob Herring
2019-06-25 7:55 ` Maxime Ripard [this message]
2019-06-25 14:15 ` Rob Herring
2019-06-24 21:56 ` [PATCH v2 07/15] dt-bindings: display: Convert pda,91-00156-a0 " Rob Herring
2019-06-25 7:56 ` Maxime Ripard
2019-06-24 21:56 ` [PATCH v2 08/15] dt-bindings: display: Convert raspberrypi,7inch-touchscreen " Rob Herring
2019-06-25 7:56 ` Maxime Ripard
2019-06-24 21:56 ` [PATCH v2 09/15] dt-bindings: display: Convert tfc,s9700rtwv43tr-01b " Rob Herring
2019-06-25 7:57 ` Maxime Ripard
2019-06-24 21:56 ` [PATCH v2 10/15] dt-bindings: display: Convert tpo,tpg110 " Rob Herring
2019-06-24 22:13 ` Linus Walleij
2019-06-24 22:47 ` Rob Herring
2019-06-25 8:26 ` Linus Walleij
2019-06-25 14:25 ` Rob Herring
2019-06-25 21:47 ` Linus Walleij
2019-06-25 8:00 ` Maxime Ripard
2019-06-24 21:56 ` [PATCH v2 11/15] dt-bindings: display: Convert panel-lvds " Rob Herring
2019-06-24 21:56 ` [PATCH v2 12/15] dt-bindings: display: Convert innolux,ee101ia-01 panel " Rob Herring
2019-06-24 21:56 ` [PATCH v2 13/15] dt-bindings: display: Convert mitsubishi,aa104xd12 " Rob Herring
2019-06-25 7:58 ` Maxime Ripard
2019-06-24 21:56 ` [PATCH v2 14/15] dt-bindings: display: Convert mitsubishi,aa121td01 " Rob Herring
2019-06-25 7:59 ` Maxime Ripard
2019-06-24 21:56 ` [PATCH v2 15/15] dt-bindings: display: Convert sgd,gktw70sdae4se " Rob Herring
2019-06-25 7:59 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625075542.u5kzex4cbrcss5ga@flea \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).