From: Will Deacon <will@kernel.org>
To: will.deacon@arm.com, tglx@linutronix.de, frederic@kernel.org,
mingo@kernel.org, longman@redhat.com, bvanassche@acm.org,
paulmck@linux.vnet.ibm.com, peterz@infradead.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
arnd@arndb.de, duyuyang@gmail.com, torvalds@linux-foundation.org,
hpa@zytor.com
Subject: Re: [tip:locking/core] locking/lockdep: Move mark_lock() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING
Date: Tue, 25 Jun 2019 13:16:25 +0100 [thread overview]
Message-ID: <20190625121624.nypo3qmbtfpl5f4r@willie-the-truck> (raw)
In-Reply-To: <tip-886532aee3cd42d95196601ed16d7c3d4679e9e5@git.kernel.org>
On Tue, Jun 25, 2019 at 01:46:07AM -0700, tip-bot for Arnd Bergmann wrote:
> Commit-ID: 886532aee3cd42d95196601ed16d7c3d4679e9e5
> Gitweb: https://git.kernel.org/tip/886532aee3cd42d95196601ed16d7c3d4679e9e5
> Author: Arnd Bergmann <arnd@arndb.de>
> AuthorDate: Mon, 17 Jun 2019 14:47:05 +0200
> Committer: Ingo Molnar <mingo@kernel.org>
> CommitDate: Tue, 25 Jun 2019 10:17:07 +0200
>
> locking/lockdep: Move mark_lock() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING
>
> The last cleanup patch triggered another issue, as now another function
> should be moved into the same section:
>
> kernel/locking/lockdep.c:3580:12: error: 'mark_lock' defined but not used [-Werror=unused-function]
> static int mark_lock(struct task_struct *curr, struct held_lock *this,
>
> Move mark_lock() into the same #ifdef section as its only caller, and
> remove the now-unused mark_lock_irq() stub helper.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Bart Van Assche <bvanassche@acm.org>
> Cc: Frederic Weisbecker <frederic@kernel.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Waiman Long <longman@redhat.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Yuyang Du <duyuyang@gmail.com>
> Fixes: 0d2cc3b34532 ("locking/lockdep: Move valid_state() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING")
> Link: https://lkml.kernel.org/r/20190617124718.1232976-1-arnd@arndb.de
> Signed-off-by: Ingo Molnar <mingo@kernel.org>
> ---
> kernel/locking/lockdep.c | 73 ++++++++++++++++++++++--------------------------
> 1 file changed, 34 insertions(+), 39 deletions(-)
Hmm, I was hoping we could fold in the simplification that Arnd came up with
yesterday:
https://lkml.kernel.org/r/CAK8P3a2X_5p9QOKG-jcozR4P8iPNJAY2ObXgfqt=bBD+hZdnSg@mail.gmail.com
Will
prev parent reply other threads:[~2019-06-25 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 12:47 [PATCH] locking/lockdep: Move mark_lock() inside CONFIG_TRACE_IRQFLAGS && CONFIG_PROVE_LOCKING Arnd Bergmann
2019-06-24 12:17 ` Will Deacon
2019-06-24 16:07 ` Arnd Bergmann
2019-06-25 8:46 ` [tip:locking/core] " tip-bot for Arnd Bergmann
2019-06-25 12:16 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625121624.nypo3qmbtfpl5f4r@willie-the-truck \
--to=will@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bvanassche@acm.org \
--cc=duyuyang@gmail.com \
--cc=frederic@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).