From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B37B8C48BD6 for ; Tue, 25 Jun 2019 19:38:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B2C4208CB for ; Tue, 25 Jun 2019 19:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561491480; bh=tJdGNjp4NLA7f2CJGKITTf6uA4kMX96bLEi69D1RpFc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=qfFEuQ2aGHyDmtpBC/FJiM7oAYrxPWIi3OthA7jpRQ+mztbz0xs6+yUOG8iVyegoq b3s/sdeT/hppCH7yrARcFOfA1MFTVYBSBUcxp7OB+Rl+d90YK3ip685UVf5husCHxR Grwt7BT+eSj9XXO43Qo/OC6lpIrhowoEUaFLhVDw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728552AbfFYTh7 (ORCPT ); Tue, 25 Jun 2019 15:37:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:46580 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726653AbfFYTh6 (ORCPT ); Tue, 25 Jun 2019 15:37:58 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C012D2085A; Tue, 25 Jun 2019 19:37:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561491478; bh=tJdGNjp4NLA7f2CJGKITTf6uA4kMX96bLEi69D1RpFc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ShVOA7PYXmmz24tjLGDu1PYm64KCDa4yjeLXa3l6FjdwwPWxrgsVBDxgsovdp7feN blu+puyvqldhGC0Wxv3kVwuVBCy18spQuzJMsEad+C5F0wrxmqqgxgvTR3f1e5CyBT eX6OYwNFOGaN5Cpc8zEu5AANzUORLi6PZJBbAynU= Date: Tue, 25 Jun 2019 12:37:57 -0700 From: Andrew Morton To: Christoph Hellwig Cc: Linus Torvalds , Paul Burton , James Hogan , Yoshinori Sato , Rich Felker , "David S. Miller" , Nicholas Piggin , Khalid Aziz , Andrey Konovalov , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linux-mips@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 14/16] mm: move the powerpc hugepd code to mm/gup.c Message-Id: <20190625123757.ec7e886747bb5a9bc364107d@linux-foundation.org> In-Reply-To: <20190625143715.1689-15-hch@lst.de> References: <20190625143715.1689-1-hch@lst.de> <20190625143715.1689-15-hch@lst.de> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jun 2019 16:37:13 +0200 Christoph Hellwig wrote: > +static int gup_huge_pd(hugepd_t hugepd Naming nitlet: we have hugepd and we also have huge_pd. We have hugepte and we also have huge_pte. It make things a bit hard to remember and it would be nice to make it all consistent sometime. We're consistent with huge_pud and almost consistent with huge_pmd. To be fully consistent I guess we should make all of them have the underscore. Or not have it.