From: Emil Velikov <emil.velikov@collabora.com>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
Cc: Russell King - ARM Linux admin <linux@armlinux.org.uk>,
linux-samsung-soc@vger.kernel.org,
Joonyoung Shim <jy0922.shim@samsung.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
Inki Dae <inki.dae@samsung.com>, David Airlie <airlied@linux.ie>,
Kyungmin Park <kyungmin.park@samsung.com>,
Kukjin Kim <kgene@kernel.org>,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
kernel@collabora.com, Sean Paul <sean@poorly.run>,
linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: Re: [PATCH 0/2] Associate ddc adapters with connectors
Date: Tue, 25 Jun 2019 14:36:39 +0100 [thread overview]
Message-ID: <20190625133639.GA16031@arch-x1c3> (raw)
In-Reply-To: <817ccfba-754c-6a28-8d75-63f70605fd43@collabora.com>
On 2019/06/25, Andrzej Pietrasiewicz wrote:
> Hi Russell,
>
> W dniu 25.06.2019 o 12:03, Russell King - ARM Linux admin pisze:
> > On Tue, Jun 25, 2019 at 11:46:34AM +0200, Andrzej Pietrasiewicz wrote:
> > > It is difficult for a user to know which of the i2c adapters is for which
> > > drm connector. This series addresses this problem.
> > >
> > > The idea is to have a symbolic link in connector's sysfs directory, e.g.:
> > >
> > > ls -l /sys/class/drm/card0-HDMI-A-1/i2c-2
> > > lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/i2c-2 \
> > > -> ../../../../soc/13880000.i2c/i2c-2
> >
> > Don't you want the symlink name to be "i2c" or something fixed, rather
> > than the name of the i2c adapter? Otherwise, you seem to be encumbering
> > userspace with searching the directory to try and find the symlink.
> >
>
> Thank you for your comment. So you imagine something on the lines of:
>
> lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \
> -> ../../../../soc/13880000.i2c/i2c-2
>
> ?
>
Fwiw my Intel machine lists a number of i2c devices:
/sys/class/drm/card0-DP-1/i2c-6
/sys/class/drm/card0-DP-2/i2c-7
/sys/class/drm/card0-eDP-1/i2c-5
Note: I haven't looked _if_ they relate to ones you're proposing here.
One thing worth mentioning is, the ones I've seen are not symlinks to
another sysfs entries. And there aren't any i2c nodes in /dev ...
Just a random food for thought :-)
HTH
Emil
next prev parent reply other threads:[~2019-06-25 13:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 9:46 [PATCH 0/2] Associate ddc adapters with connectors Andrzej Pietrasiewicz
2019-06-25 9:46 ` [PATCH 1/2] drm: Include ddc adapter pointer in struct drm_connector Andrzej Pietrasiewicz
2019-06-25 9:46 ` [PATCH 2/2] drm/exynos: Provide ddc symlink in connector's sysfs Andrzej Pietrasiewicz
2019-06-25 10:03 ` [PATCH 0/2] Associate ddc adapters with connectors Russell King - ARM Linux admin
2019-06-25 10:14 ` Andrzej Pietrasiewicz
2019-06-25 10:16 ` Russell King - ARM Linux admin
2019-06-25 10:24 ` [PATCH v2 " Andrzej Pietrasiewicz
2019-06-25 10:24 ` [PATCH v2 1/2] drm: Include ddc adapter pointer in struct drm_connector Andrzej Pietrasiewicz
2019-06-25 14:21 ` Daniel Vetter
2019-06-25 10:24 ` [PATCH v2 2/2] drm/exynos: Provide ddc symlink in connector's sysfs Andrzej Pietrasiewicz
2019-06-25 13:36 ` Emil Velikov [this message]
2019-06-25 14:07 ` [PATCH 0/2] Associate ddc adapters with connectors Daniel Vetter
2019-06-25 14:10 ` Russell King - ARM Linux admin
2019-06-25 14:20 ` Daniel Vetter
2019-06-26 6:50 ` Andrzej Pietrasiewicz
[not found] ` <cover.1561735433.git.andrzej.p@collabora.com>
[not found] ` <d6381c020ea1c848a7044d830bdb0ec9663d1619.1561735433.git.andrzej.p@collabora.com>
[not found] ` <9b03d145-ec50-927c-55a8-dff1cd51d655@suse.de>
[not found] ` <cf1984e4-50af-302d-ef67-9ad530118c29@collabora.com>
[not found] ` <CGME20190701144119epcas1p211ec60b63f3c6ae02392e2ae67f1a4ba@epcas1p2.samsung.com>
[not found] ` <9e65f3c0-941d-d04c-5745-6b3a2965b990@suse.de>
2019-07-05 9:44 ` [PATCH v3 01/22] drm: Include ddc adapter pointer in struct drm_connector Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625133639.GA16031@arch-x1c3 \
--to=emil.velikov@collabora.com \
--cc=airlied@linux.ie \
--cc=andrzej.p@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kernel@collabora.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).