From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF383C48BD5 for ; Tue, 25 Jun 2019 18:16:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9031F2080C for ; Tue, 25 Jun 2019 18:16:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732808AbfFYSQC (ORCPT ); Tue, 25 Jun 2019 14:16:02 -0400 Received: from gate.crashing.org ([63.228.1.57]:45226 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729748AbfFYSQC (ORCPT ); Tue, 25 Jun 2019 14:16:02 -0400 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id x5PIFp1g019975; Tue, 25 Jun 2019 13:15:51 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id x5PIFnSa019974; Tue, 25 Jun 2019 13:15:49 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Tue, 25 Jun 2019 13:15:49 -0500 From: Segher Boessenkool To: Mathieu Malaterre Cc: Michael Ellerman , Joel Stanley , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] lib/mpi: fix build with clang Message-ID: <20190625181549.GK7313@gate.crashing.org> References: <20190621071342.17897-1-malat@debian.org> <20190621195555.20615-1-malat@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190621195555.20615-1-malat@debian.org> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mathieu, On Fri, Jun 21, 2019 at 09:55:54PM +0200, Mathieu Malaterre wrote: > Remove superfluous casts on output operands to avoid warnings on the > following macros: > > * add_ssaaaa(sh, sl, ah, al, bh, bl) > * sub_ddmmss(sh, sl, ah, al, bh, bl) > * umul_ppmm(ph, pl, m0, m1) The patch is fine of course, but you might want to look at not using these asm macros at all: GCC can handle multi-word arithmetic just fine by itself, probably better than these macros do even. Segher