From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=FROM_EXCESS_BASE64, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCCE6C48BD4 for ; Tue, 25 Jun 2019 16:48:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A018F204FD for ; Tue, 25 Jun 2019 16:48:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730841AbfFYQsy (ORCPT ); Tue, 25 Jun 2019 12:48:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:54208 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727872AbfFYQsw (ORCPT ); Tue, 25 Jun 2019 12:48:52 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9D38AAD4E; Tue, 25 Jun 2019 16:48:50 +0000 (UTC) Date: Tue, 25 Jun 2019 18:48:48 +0200 From: Michal =?UTF-8?B?U3VjaMOhbmVr?= To: Eric Biggers Cc: linux-crypto@vger.kernel.org, chetjain@in.ibm.com, Herbert Xu , "David S. Miller" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: algapi - guard against uninitialized spawn list in crypto_remove_spawns Message-ID: <20190625184848.1b2e5dfe@kitsune.suse.cz> In-Reply-To: <20190625164052.GA81914@gmail.com> References: <20190625071624.27039-1-msuchanek@suse.de> <20190625164052.GA81914@gmail.com> Organization: SUSE Linux X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Jun 2019 09:40:54 -0700 Eric Biggers wrote: Hello, > Hi Michal, > > The stack trace shows that crypto_remove_spawns() is being called from > crypto_unregister_instance(). Therefore, the instance should already be > registered and have initialized cra_users. Now, I don't claim to understand the > spawn lists stuff that well, so I could have missed something; but if there *is* > a bug, I'd like to see a proper explanation. Unfortunately, I don't have an explanation either. > > Did you check whether this is actually reproducible on mainline, and not just > the SUSE v4.12 based kernel? Mainline crashes on boot:/ Need to find a recent working kernel. Thanks Michal