From: Rajat Jain <rajatja@google.com>
To: Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org
Cc: evgreen@google.com, rajatxjain@gmail.com,
Rajat Jain <rajatja@google.com>
Subject: [PATCH] platform/chrome: lightbar: Assign drvdata during probe
Date: Tue, 25 Jun 2019 13:51:01 -0700 [thread overview]
Message-ID: <20190625205101.33032-1-rajatja@google.com> (raw)
The lightbar driver never assigned the drvdata in probe method, and thus
causes a panic when it is accessed at the suspend time.
Signed-off-by: Rajat Jain <rajatja@google.com>
---
drivers/platform/chrome/cros_ec_lightbar.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
index d30a6650b0b5..98e514fc5830 100644
--- a/drivers/platform/chrome/cros_ec_lightbar.c
+++ b/drivers/platform/chrome/cros_ec_lightbar.c
@@ -578,11 +578,14 @@ static int cros_ec_lightbar_probe(struct platform_device *pd)
ret = sysfs_create_group(&ec_dev->class_dev.kobj,
&cros_ec_lightbar_attr_group);
- if (ret < 0)
+ if (ret < 0) {
dev_err(dev, "failed to create %s attributes. err=%d\n",
cros_ec_lightbar_attr_group.name, ret);
+ return ret;
+ }
- return ret;
+ platform_set_drvdata(pd, ec_dev);
+ return 0;
}
static int cros_ec_lightbar_remove(struct platform_device *pd)
--
2.22.0.410.gd8fdbe21b5-goog
next reply other threads:[~2019-06-25 20:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 20:51 Rajat Jain [this message]
2019-06-26 20:34 ` [PATCH] platform/chrome: lightbar: Assign drvdata during probe Enric Balletbo i Serra
2019-06-27 21:41 ` Rajat Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625205101.33032-1-rajatja@google.com \
--to=rajatja@google.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=evgreen@google.com \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajatxjain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).