From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A35EEC48BD7 for ; Tue, 25 Jun 2019 22:42:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 70B142086D for ; Tue, 25 Jun 2019 22:42:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561502543; bh=KouZu5qnypdtE8X3me3dX90B1JxpSh5C4RafRD60fCM=; h=In-Reply-To:References:To:From:Subject:Cc:Date:List-ID:From; b=RyxgDGe9YIkMZBQnhjfIBXlhopw258y/RPhTDXmvinx7OfToGaO+aoidlGV8f5mwd z2HbPegsTKzdGhI6DvBgGwG8IAPOAvct96TI8DR47DergV1QIeN+/qagT5FA+TOhvf eynvDqo5HKwQkaoe0NsOSJhFkSUzYRKtCFlY9H0o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726413AbfFYWmW (ORCPT ); Tue, 25 Jun 2019 18:42:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:42232 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725782AbfFYWmW (ORCPT ); Tue, 25 Jun 2019 18:42:22 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2643520645; Tue, 25 Jun 2019 22:42:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561502541; bh=KouZu5qnypdtE8X3me3dX90B1JxpSh5C4RafRD60fCM=; h=In-Reply-To:References:To:From:Subject:Cc:Date:From; b=OEzP8BP4Lowoj6agjatrsqH4p0/Rlwt9Wqqhp+TLMA8djoRnhxsT5RYrNFEDN/EC+ i9ShFoH6/UnIjVb6AzY5jsAqX5OGuJ9NV43putA86b4kunILYqDfbQM8LkBi45HHTN +u1I+xQvL+o7DqJG8KziRJ6JRxCFYuVYXbKYtb2o= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20190625221736.853892086D@mail.kernel.org> References: <20190611180757.32299-1-paul@crapouillou.net> <20190625221736.853892086D@mail.kernel.org> To: James Hogan , Michael Turquette , Paul Burton , Paul Cercueil , Ralf Baechle From: Stephen Boyd Subject: Re: [PATCH v2 1/5] clk: ingenic: Add missing header in cgu.h Cc: od@zcrc.me, linux-mips@vger.kernel.org, linux-pm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Cercueil User-Agent: alot/0.8.1 Date: Tue, 25 Jun 2019 15:42:20 -0700 Message-Id: <20190625224221.2643520645@mail.kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Stephen Boyd (2019-06-25 15:17:35) > Quoting Paul Cercueil (2019-06-11 11:07:53) > > The cgu.h has structures that contain 'clk_onecell_data' and 'clk_hw' > > structures (no pointers), so the header should be > > included. > >=20 > > Signed-off-by: Paul Cercueil > > --- > >=20 > > Notes: > > v2: Rebase on v5.2-rc4 >=20 > You seemed to miss my review comments on patch set #1. >=20 > https://lkml.kernel.org/r/155726035790.14659.7321778387595703949@swboyd.m= tv.corp.google.com >=20 I've just decided to fix it instead of wait. Let me know if that's a problem.