From: Dan Carpenter <dan.carpenter@oracle.com>
To: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Nishka Dasgupta <nishkadg.linux@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: hal: sdio_halinit: Remove set but unused varilable pHalData
Date: Thu, 27 Jun 2019 09:38:35 +0300 [thread overview]
Message-ID: <20190627063835.GH28859@kadam> (raw)
In-Reply-To: <20190626174459.GA8539@hari-Inspiron-1545>
On Wed, Jun 26, 2019 at 11:14:59PM +0530, Hariprasad Kelam wrote:
> @@ -1433,7 +1430,6 @@ static void SetHwReg8723BS(struct adapter *padapter, u8 variable, u8 *val)
> #endif
> #endif
>
> - pHalData = GET_HAL_DATA(padapter);
>
> switch (variable) {
We need to delete one of those blank lines or it introduces a new
checkpatch warning.
regards,
dan carpenter
next prev parent reply other threads:[~2019-06-27 6:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 17:44 [PATCH] staging: rtl8723bs: hal: sdio_halinit: Remove set but unused varilable pHalData Hariprasad Kelam
2019-06-27 6:38 ` Dan Carpenter [this message]
2019-06-27 18:05 ` Hariprasad Kelam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627063835.GH28859@kadam \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hariprasad.kelam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nishkadg.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).