From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C95D5C48BD7 for ; Thu, 27 Jun 2019 12:12:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A45462080C for ; Thu, 27 Jun 2019 12:12:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726883AbfF0MMC (ORCPT ); Thu, 27 Jun 2019 08:12:02 -0400 Received: from muru.com ([72.249.23.125]:53730 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726465AbfF0MMB (ORCPT ); Thu, 27 Jun 2019 08:12:01 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 4CED2805C; Thu, 27 Jun 2019 12:12:24 +0000 (UTC) Date: Thu, 27 Jun 2019 05:11:58 -0700 From: Tony Lindgren To: Suman Anna Cc: Tero Kristo , Roger Quadros , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] bus: ti-sysc: Simplify cleanup upon failures in sysc_probe() Message-ID: <20190627121158.GJ5447@atomide.com> References: <20190625233315.22301-1-s-anna@ti.com> <20190625233315.22301-6-s-anna@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190625233315.22301-6-s-anna@ti.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Suman Anna [190625 23:33]: > The clocks are not yet parsed and prepared until after a successful > sysc_get_clocks(), so there is no need to unprepare the clocks upon > any failure of any of the prior functions in sysc_probe(). The current > code path would have been a no-op because of the clock validity checks > within sysc_unprepare(), but let's just simplify the cleanup path by > returning the error directly. > > While at this, also fix the cleanup path for a sysc_init_resets() > failure which is executed after the clocks are prepared. Sounds like this should get queued separately as a fix for v5.3-rc cycle, probably got broken with the recent ti-sysc init order changes. Regards, Tony