linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Keerthy <j-keerthy@ti.com>
Cc: <t-kristo@ti.com>, <will.deacon@arm.com>,
	<catalin.marinas@arm.com>, <shawnguo@kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <lokeshvutla@ti.com>
Subject: Re: [PATCH v2] arm64: Kconfig.platforms: Enable GPIO_DAVINCI for ARCH_K3
Date: Thu, 27 Jun 2019 09:32:08 -0500	[thread overview]
Message-ID: <20190627143208.eeca4xyygml7s4n3@kahuna> (raw)
In-Reply-To: <20190627110920.15099-1-j-keerthy@ti.com>

On 16:39-20190627, Keerthy wrote:
> Enable GPIO_DAVINCI and related configs for TI K3 AM6 platforms.
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> 
> Changes in v2:
> 
>   * Enabling configs in Kconfig.platforms file instead of defconfig.
>   * Removed GPIO_DEBUG config.
> 
>  arch/arm64/Kconfig.platforms | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 4778c775de1b..6e43a0995ed4 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -97,6 +97,8 @@ config ARCH_K3
>  	select TI_SCI_PROTOCOL
>  	select TI_SCI_INTR_IRQCHIP
>  	select TI_SCI_INTA_IRQCHIP
> +	select GPIO_SYSFS
> +	select GPIO_DAVINCI


Could you help explain the logic of doing this? commit message is
basically the diff in English. To me, this does NOT make sense.

I understand GPIO_DAVINCI is the driver compatible, but we cant do this for
every single SoC driver that is NOT absolutely mandatory for basic
functionality.

Also keep in mind the impact to arm64/configs/defconfig -> every single
SoC in the arm64 world will be now rebuild with GPIO_SYSFS.. why force
that?

-- 
Regards,
Nishanth Menon

  reply	other threads:[~2019-06-27 14:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 11:09 [PATCH v2] arm64: Kconfig.platforms: Enable GPIO_DAVINCI for ARCH_K3 Keerthy
2019-06-27 14:32 ` Nishanth Menon [this message]
2019-06-28  3:38   ` Keerthy
2019-06-28 20:37     ` Nishanth Menon
2019-07-11  5:49       ` Keerthy
2019-07-11  7:16         ` Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190627143208.eeca4xyygml7s4n3@kahuna \
    --to=nm@ti.com \
    --cc=catalin.marinas@arm.com \
    --cc=j-keerthy@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=shawnguo@kernel.org \
    --cc=t-kristo@ti.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).