linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Christian Müller" <muellerch-privat@web.de>
Cc: devel@driverdev.osuosl.org,
	Felix Trommer <felix.trommer@hotmail.de>,
	linux-kernel@i4.cs.fau.de, linux-kernel@vger.kernel.org,
	johnfwhitmore@gmail.com
Subject: Re: [PATCH v2 1/2] drivers/staging/rtl8192u: drop first comment line
Date: Fri, 28 Jun 2019 00:45:30 +0800	[thread overview]
Message-ID: <20190627164530.GD9692@kroah.com> (raw)
In-Reply-To: <20190627083336.3897-1-muellerch-privat@web.de>

On Thu, Jun 27, 2019 at 10:33:35AM +0200, Christian Müller wrote:
> As stated in coding-styles.rst multiline comments should be structured in a way,
> that the actual comment starts on the second line of the commented portion. E.g:
> 
> /*
>  * Multiline comments
>  * should look like
>  * this.
>  */
> 
> However, there is an exception to files in drivers/net/ and net/, where
> multiline comments are prefered to look like this:
> 
> /* Mutliline comments for
>  * drivers/net/ should look
>  * like this.
>  */
> 
> The comments in this file initially looked like the first example.
> But since this file is part of a networking driver and thus should
> be moved to drivers/net/ one day, this patch adjusts the comments
> such that they are fitting to the style imposed for drivers/net/.
> 
> Signed-off-by: Christian Müller <muellerch-privat@web.de>
> Signed-off-by: Felix Trommer <felix.trommer@hotmail.de>
> ---
>  drivers/staging/rtl8192u/r8192U_dm.c | 69 ++++++++++------------------
>  1 file changed, 23 insertions(+), 46 deletions(-)

What changed from v1?  That always goes below the --- line.

Please fix up and send v3.

thanks,

greg k-h

  parent reply	other threads:[~2019-06-27 16:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-20  9:45 [PATCH 0/1] drivers/staging/rtl8192u: adjust block comments Christian Müller
2019-06-20  9:45 ` [PATCH 1/1] drivers/staging/rtl8129u: " Christian Müller
2019-06-20 11:33   ` Greg KH
2019-06-24  9:46     ` [PATCH 0/2] drivers/staging/rtl8192u: " Christian Müller
2019-06-24  9:46       ` [PATCH 1/2] " Christian Müller
2019-06-26  1:53         ` Greg KH
2019-06-27  8:33           ` [PATCH v2 1/2] drivers/staging/rtl8192u: drop first comment line Christian Müller
2019-06-27  8:33             ` [PATCH v2 2/2] drivers/staging/rtl8192u: style nonstyled comments Christian Müller
2019-06-27 16:45             ` Greg KH [this message]
2019-07-01  8:27               ` [PATCH v3 1/2] drivers/staging/rtl8192u: drop first comment line Christian Müller
2019-07-01  8:27                 ` [PATCH v3 2/2] drivers/staging/rtl8192u: style nonstyled comments Christian Müller
2019-06-24  9:46       ` [PATCH 2/2] drivers/staging/rtl8192u: adjust block comments Christian Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190627164530.GD9692@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=felix.trommer@hotmail.de \
    --cc=johnfwhitmore@gmail.com \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=muellerch-privat@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).