From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4037FC48BD9 for ; Thu, 27 Jun 2019 17:06:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1991A2146E for ; Thu, 27 Jun 2019 17:06:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726632AbfF0RGz convert rfc822-to-8bit (ORCPT ); Thu, 27 Jun 2019 13:06:55 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:48951 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726405AbfF0RGz (ORCPT ); Thu, 27 Jun 2019 13:06:55 -0400 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 8FDC2240003; Thu, 27 Jun 2019 17:06:46 +0000 (UTC) Date: Thu, 27 Jun 2019 19:06:44 +0200 From: Miquel Raynal To: Schrempf Frieder Cc: liaoweixiong , Greg KH , Vignesh Raghavendra , Boris Brezillon , "Richard Weinberger" , "linux-kernel@vger.kernel.org" , Chuanhong Guo , "Marek Vasut" , "linux-mtd@lists.infradead.org" , "stable@vger.kernel.org" , Brian Norris , David Woodhouse Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips Message-ID: <20190627190644.25aaaf31@xps13> In-Reply-To: <97adf58f-4771-90f1-bdaf-5a9d00eef768@kontron.de> References: <1561424549-784-1-git-send-email-liaoweixiong@allwinnertech.com> <20190625030807.GA11074@kroah.com> <97adf58f-4771-90f1-bdaf-5a9d00eef768@kontron.de> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Schrempf Frieder wrote on Tue, 25 Jun 2019 07:04:06 +0000: > Hi liaoweixiong, > > On 25.06.19 05:08, Greg KH wrote: > > On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote: > >> In case of the last page containing bitflips (ret > 0), > >> spinand_mtd_read() will return that number of bitflips for the last > >> page. But to me it looks like it should instead return max_bitflips like > >> it does when the last page read returns with 0. > >> > >> Signed-off-by: liaoweixiong Please write your entire official first/last name(s) > >> Reviewed-by: Boris Brezillon > >> Reviewed-by: Frieder Schrempf I am waiting your next version with Acked-by instead of Rewieved-by tags and Greg's comment addressed. > >> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") Finally, when we ask you to resend a patch, it means sending a new version of the patch. So in the subject, you should not use the [RESEND] keyword (which means you are sending something again exactly as it was before, you just got ignored, for example) but instead you should increment the version number (v3) and also write a nice changelog after the three dashes '---' (will be ignored by Git when applying). I would like to queue this for the next release so if you can do it ASAP, that would be great. Thank you, Miquèl