From: Eric Biggers <ebiggers@kernel.org>
To: keerthy <j-keerthy@ti.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net,
robh+dt@kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
t-kristo@ti.com, linux-crypto@vger.kernel.org, nm@ti.com
Subject: Re: [RESEND PATCH 00/10] crypto: k3: Add sa2ul driver
Date: Thu, 27 Jun 2019 22:25:44 -0700 [thread overview]
Message-ID: <20190628052544.GH673@sol.localdomain> (raw)
In-Reply-To: <7ca64e49-6e1f-c74e-4d8e-0e08607fe5c5@ti.com>
On Fri, Jun 28, 2019 at 10:44:26AM +0530, keerthy wrote:
>
>
> On 6/28/2019 10:23 AM, Eric Biggers wrote:
> > Hi Keerthy,
> >
> > On Fri, Jun 28, 2019 at 09:57:35AM +0530, Keerthy wrote:
> > > The series adds Crypto hardware accelerator support for SA2UL.
> > > SA2UL stands for security accelerator ultra lite.
> > >
> > > The Security Accelerator (SA2_UL) subsystem provides hardware
> > > cryptographic acceleration for the following use cases:
> > > • Encryption and authentication for secure boot
> > > • Encryption and authentication of content in applications
> > > requiring DRM (digital rights management) and
> > > content/asset protection
> > > The device includes one instantiation of SA2_UL named SA2_UL0
> > >
> > > SA2UL needs on tx channel and a pair of rx dma channels.
> > >
> > > This series has dependency on UDMA series. Hence is based on top of:
> > >
> > > https://patchwork.kernel.org/project/linux-dmaengine/list/?series=114105
> > >
> > > The above series adds couple of dmaengine APIs that are used
> > > by the sa2ul driver. Hence there is a hard dependency on the
> > > above series.
> > >
> > > Resending with linux-crypto list in Cc.
> > >
> > > Keerthy (10):
> > > dt-bindings: crypto: k3: Add sa2ul bindings documentation
> > > crypto: sa2ul: Add crypto driver
> > > crypto: sa2ul: Add AES ECB Mode support
> > > crypto: sa2ul: Add aead support for hmac(sha1)cbc(aes) algorithm
> > > crypto: sha256_generic: Export the Transform function
> > > crypto: sa2ul: Add hmac(sha256)cbc(aes) AEAD Algo support
> > > crypto: sa2ul: Add hmac(sha1) HMAC algorithm support
> > > crypto: sa2ul: Add hmac(sha256) HMAC algorithm support
> > > sa2ul: Add 3DES ECB & CBC Mode support
> > > arm64: dts: k3-am6: Add crypto accelarator node
> > >
> > > .../devicetree/bindings/crypto/sa2ul.txt | 47 +
> > > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 33 +
> > > crypto/sha256_generic.c | 3 +-
> > > drivers/crypto/Kconfig | 17 +
> > > drivers/crypto/Makefile | 1 +
> > > drivers/crypto/sa2ul.c | 2232 +++++++++++++++++
> > > drivers/crypto/sa2ul.h | 384 +++
> > > include/crypto/sha.h | 1 +
> > > 8 files changed, 2717 insertions(+), 1 deletion(-)
> > > create mode 100644 Documentation/devicetree/bindings/crypto/sa2ul.txt
> > > create mode 100644 drivers/crypto/sa2ul.c
> > > create mode 100644 drivers/crypto/sa2ul.h
> >
> > Did you run the crypto self-tests on this driver? i.e. boot a kernel with
> >
> > # CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set
> > CONFIG_DEBUG_KERNEL=y
> > CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y
> >
> > What are the results?
>
> Eric,
>
> Thanks for your response. I did try with that. All test cases
> were passing on 4.19 kernel before the testmgr revamp.
>
That's surprising, since your driver doesn't implement update() for hashing, so
it should have been failing at least the HMAC tests. Are you sure you really
ran the tests?
> Currently few of the test cases do fail. For ex: Appending
> the last ivlen bytes of cipher text as the IV.
Well, these need to be fixed.
>
> >
> > Also, this patchset does not compile for me.
>
> This has dependency on UDMA series:
> https://patchwork.kernel.org/cover/10930969/
I had that applied.
- Eric
next prev parent reply other threads:[~2019-06-28 5:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 4:27 [RESEND PATCH 00/10] crypto: k3: Add sa2ul driver Keerthy
2019-06-28 4:27 ` [RESEND PATCH 01/10] dt-bindings: crypto: k3: Add sa2ul bindings documentation Keerthy
2019-07-22 18:29 ` Rob Herring
2019-07-23 4:11 ` Keerthy
2019-06-28 4:27 ` [RESEND PATCH 02/10] crypto: sa2ul: Add crypto driver Keerthy
2019-06-28 5:07 ` Eric Biggers
2019-06-28 5:24 ` Keerthy
2019-06-28 4:27 ` [RESEND PATCH 03/10] crypto: sa2ul: Add AES ECB Mode support Keerthy
2019-06-28 4:27 ` [RESEND PATCH 04/10] crypto: sa2ul: Add aead support for hmac(sha1)cbc(aes) algorithm Keerthy
2019-06-28 4:27 ` [RESEND PATCH 05/10] crypto: sha256_generic: Export the Transform function Keerthy
2019-06-28 5:09 ` Eric Biggers
2019-06-28 5:27 ` Keerthy
2019-06-28 4:27 ` [RESEND PATCH 06/10] crypto: sa2ul: Add hmac(sha256)cbc(aes) AEAD Algo support Keerthy
2019-06-28 5:12 ` Eric Biggers
2019-06-28 4:27 ` [RESEND PATCH 07/10] crypto: sa2ul: Add hmac(sha1) HMAC algorithm support Keerthy
2019-06-28 5:14 ` Eric Biggers
2019-06-28 5:32 ` Keerthy
2019-06-28 4:27 ` [RESEND PATCH 08/10] crypto: sa2ul: Add hmac(sha256) " Keerthy
2019-06-28 4:27 ` [RESEND PATCH 09/10] sa2ul: Add 3DES ECB & CBC Mode support Keerthy
2019-06-28 4:27 ` [RESEND PATCH 10/10] arm64: dts: k3-am6: Add crypto accelarator node Keerthy
2019-06-28 4:53 ` [RESEND PATCH 00/10] crypto: k3: Add sa2ul driver Eric Biggers
2019-06-28 5:14 ` keerthy
2019-06-28 5:25 ` Eric Biggers [this message]
2019-06-28 5:31 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628052544.GH673@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).