From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB0F5C4321A for ; Fri, 28 Jun 2019 12:27:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF912208C4 for ; Fri, 28 Jun 2019 12:27:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726839AbfF1M1o (ORCPT ); Fri, 28 Jun 2019 08:27:44 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42304 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726558AbfF1M1n (ORCPT ); Fri, 28 Jun 2019 08:27:43 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5SCRbIY026621 for ; Fri, 28 Jun 2019 08:27:42 -0400 Received: from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203]) by mx0a-001b2d01.pphosted.com with ESMTP id 2tdgc5e570-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 28 Jun 2019 08:27:42 -0400 Received: from localhost by e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 28 Jun 2019 13:27:41 +0100 Received: from b01cxnp22034.gho.pok.ibm.com (9.57.198.24) by e13.ny.us.ibm.com (146.89.104.200) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Fri, 28 Jun 2019 13:27:36 +0100 Received: from b01ledav003.gho.pok.ibm.com (b01ledav003.gho.pok.ibm.com [9.57.199.108]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x5SCRZZT39584230 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 28 Jun 2019 12:27:35 GMT Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 18AA8B2068; Fri, 28 Jun 2019 12:27:35 +0000 (GMT) Received: from b01ledav003.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D5657B206C; Fri, 28 Jun 2019 12:27:34 +0000 (GMT) Received: from paulmck-ThinkPad-W541 (unknown [9.80.201.148]) by b01ledav003.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 28 Jun 2019 12:27:34 +0000 (GMT) Received: by paulmck-ThinkPad-W541 (Postfix, from userid 1000) id 5451C16C6AD7; Fri, 28 Jun 2019 05:27:35 -0700 (PDT) Date: Fri, 28 Jun 2019 05:27:35 -0700 From: "Paul E. McKenney" To: Byungchul Park Cc: Scott Wood , Joel Fernandes , Steven Rostedt , Sebastian Andrzej Siewior , rcu , LKML , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Josh Triplett , Mathieu Desnoyers , Lai Jiangshan Subject: Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs Reply-To: paulmck@linux.ibm.com References: <20190627153031.GA249127@google.com> <20190627155506.GU26519@linux.ibm.com> <20190627173831.GW26519@linux.ibm.com> <20190627181638.GA209455@google.com> <20190627184107.GA26519@linux.ibm.com> <13761fee4b71cc004ad0d6709875ce917ff28fce.camel@redhat.com> <20190627203612.GD26519@linux.ibm.com> <20190628073138.GB13650@X58A-UD3R> <20190628104045.GA8394@X58A-UD3R> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190628104045.GA8394@X58A-UD3R> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 19062812-0064-0000-0000-000003F4D9C8 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00011346; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000286; SDB=6.01224469; UDB=6.00644469; IPR=6.01005661; MB=3.00027506; MTD=3.00000008; XFM=3.00000015; UTC=2019-06-28 12:27:39 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19062812-0065-0000-0000-00003E1061B6 Message-Id: <20190628122735.GS26519@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-28_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906280148 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 28, 2019 at 07:40:45PM +0900, Byungchul Park wrote: > On Fri, Jun 28, 2019 at 04:31:38PM +0900, Byungchul Park wrote: > > On Thu, Jun 27, 2019 at 01:36:12PM -0700, Paul E. McKenney wrote: > > > On Thu, Jun 27, 2019 at 03:17:27PM -0500, Scott Wood wrote: > > > > On Thu, 2019-06-27 at 11:41 -0700, Paul E. McKenney wrote: > > > > > On Thu, Jun 27, 2019 at 02:16:38PM -0400, Joel Fernandes wrote: > > > > > > > > > > > > I think the fix should be to prevent the wake-up not based on whether we > > > > > > are > > > > > > in hard/soft-interrupt mode but that we are doing the rcu_read_unlock() > > > > > > from > > > > > > a scheduler path (if we can detect that) > > > > > > > > > > Or just don't do the wakeup at all, if it comes to that. I don't know > > > > > of any way to determine whether rcu_read_unlock() is being called from > > > > > the scheduler, but it has been some time since I asked Peter Zijlstra > > > > > about that. > > > > > > > > > > Of course, unconditionally refusing to do the wakeup might not be happy > > > > > thing for NO_HZ_FULL kernels that don't implement IRQ work. > > > > > > > > Couldn't smp_send_reschedule() be used instead? > > > > > > Good point. If current -rcu doesn't fix things for Sebastian's case, > > > that would be well worth looking at. But there must be some reason > > > why Peter Zijlstra didn't suggest it when he instead suggested using > > > the IRQ work approach. > > > > > > Peter, thoughts? > > > > Hello, > > > > Isn't the following scenario possible? > > > > The original code > > ----------------- > > rcu_read_lock(); > > ... > > /* Experdite */ > > WRITE_ONCE(t->rcu_read_unlock_special.b.exp_hint, true); > > ... > > __rcu_read_unlock(); > > if (unlikely(READ_ONCE(t->rcu_read_unlock_special.s))) > > rcu_read_unlock_special(t); > > WRITE_ONCE(t->rcu_read_unlock_special.b.exp_hint, false); > > rcu_preempt_deferred_qs_irqrestore(t, flags); > > barrier(); /* ->rcu_read_unlock_special load before assign */ > > t->rcu_read_lock_nesting = 0; > > > > The reordered code by machine > > ----------------------------- > > rcu_read_lock(); > > ... > > /* Experdite */ > > WRITE_ONCE(t->rcu_read_unlock_special.b.exp_hint, true); > > ... > > __rcu_read_unlock(); > > if (unlikely(READ_ONCE(t->rcu_read_unlock_special.s))) > > rcu_read_unlock_special(t); > > t->rcu_read_lock_nesting = 0; <--- LOOK AT THIS!!! > > WRITE_ONCE(t->rcu_read_unlock_special.b.exp_hint, false); > > rcu_preempt_deferred_qs_irqrestore(t, flags); > > barrier(); /* ->rcu_read_unlock_special load before assign */ > > > > An interrupt happens > > -------------------- > > rcu_read_lock(); > > ... > > /* Experdite */ > > WRITE_ONCE(t->rcu_read_unlock_special.b.exp_hint, true); > > ... > > __rcu_read_unlock(); > > if (unlikely(READ_ONCE(t->rcu_read_unlock_special.s))) > > rcu_read_unlock_special(t); > > t->rcu_read_lock_nesting = 0; <--- LOOK AT THIS!!! > > <--- Handle an (any) irq > > rcu_read_lock(); > > /* This call should be skipped */ > > rcu_read_unlock_special(t); > > Wait.. I got a little bit confused on recordering. > > This 'STORE rcu_read_lock_nesting = 0' can happen before > 'STORE rcu_read_unlock_special.b.exp_hint = false' regardless of the > order a compiler generated to by the barrier(), because anyway they > are independent so it's within an arch's right. > > Then.. is this scenario possible? Or all archs properly deal with > interrupts across this kind of reordering? Interrupts are "exact" in that they happen between a pair of consecutive instructions from the viewpoint of the CPU taking the interrupt. And again, these fields are local to their CPU/task, give or take debug code. Thanx, Paul > Thanks, > Byungchul > > > WRITE_ONCE(t->rcu_read_unlock_special.b.exp_hint, false); > > rcu_preempt_deferred_qs_irqrestore(t, flags); > > barrier(); /* ->rcu_read_unlock_special load before assign */ > > > > We don't have to handle the special thing twice like this which is one > > reason to cause the problem even though another problem is of course to > > call ttwu w/o being aware it's within a context holding pi lock. > > > > Apart from the discussion about how to avoid ttwu in an improper > > condition, I think the following is necessary. I may have something > > missing. It would be appreciated if you let me know in case I'm wrong. > > > > Anyway, logically I think we should prevent reordering between > > t->rcu_read_lock_nesting and t->rcu_read_unlock_special.b.exp_hint not > > only by compiler but also by machine like the below. > > > > Do I miss something? > > > > Thanks, > > Byungchul > > > > ---8<--- > > diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h > > index 3c8444e..9b137f1 100644 > > --- a/kernel/rcu/tree_plugin.h > > +++ b/kernel/rcu/tree_plugin.h > > @@ -412,7 +412,13 @@ void __rcu_read_unlock(void) > > barrier(); /* assign before ->rcu_read_unlock_special load */ > > if (unlikely(READ_ONCE(t->rcu_read_unlock_special.s))) > > rcu_read_unlock_special(t); > > - barrier(); /* ->rcu_read_unlock_special load before assign */ > > + /* > > + * Prevent reordering between clearing > > + * t->rcu_reak_unlock_special in > > + * rcu_read_unlock_special() and the following > > + * assignment to t->rcu_read_lock_nesting. > > + */ > > + smp_wmb(); > > t->rcu_read_lock_nesting = 0; > > } > > if (IS_ENABLED(CONFIG_PROVE_LOCKING)) { > > > > >