From: Guenter Roeck <linux@roeck-us.net>
To: Amy.Shih@advantech.com.tw
Cc: she90122@gmail.com, oakley.ding@advantech.com.tw,
jia.sui@advantech.com.cn, Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v2 2/9] hwmon: (nct7904) Changes comments in probe function.
Date: Fri, 28 Jun 2019 10:29:48 -0700 [thread overview]
Message-ID: <20190628172948.GA25799@roeck-us.net> (raw)
On Mon, Jun 17, 2019 at 08:10:00AM +0000, Amy.Shih@advantech.com.tw wrote:
> From: "amy.shih" <amy.shih@advantech.com.tw>
>
> Linux style for comments is the C89 "/* ... */" style,
> changes the comments to Linux style.
>
> Signed-off-by: amy.shih <amy.shih@advantech.com.tw>
Applied.
Thanks,
Guenter
> ---
> Changes in v2:
> - Fix wrong style of comments.
>
> drivers/hwmon/nct7904.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
> index 401ed4a4a576..710c30562fc1 100644
> --- a/drivers/hwmon/nct7904.c
> +++ b/drivers/hwmon/nct7904.c
> @@ -542,13 +542,13 @@ static int nct7904_probe(struct i2c_client *client,
> if (ret < 0)
> return ret;
> if (ret & 0x80) {
> - data->enable_dts = 1; //Enable DTS & PECI
> + data->enable_dts = 1; /* Enable DTS & PECI */
> } else {
> ret = nct7904_read_reg(data, BANK_2, TSI_CTRL_REG);
> if (ret < 0)
> return ret;
> if (ret & 0x80)
> - data->enable_dts = 0x3; //Enable DTS & TSI
> + data->enable_dts = 0x3; /* Enable DTS & TSI */
> }
>
> /* Check DTS enable status */
next reply other threads:[~2019-06-28 17:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 17:29 Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-06-17 8:08 [v2 1/9] hwmon: (nct7904) Add error handling in probe function Amy.Shih
2019-06-17 8:10 ` [v2 2/9] hwmon: (nct7904) Changes comments " Amy.Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628172948.GA25799@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Amy.Shih@advantech.com.tw \
--cc=jdelvare@suse.com \
--cc=jia.sui@advantech.com.cn \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oakley.ding@advantech.com.tw \
--cc=she90122@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).