From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Maxime Chevallier <maxime.chevallier@bootlin.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Russell King <linux@armlinux.org.uk>,
David Miller <davem@davemloft.net>,
brian.brooks@linaro.org, linux-kernel@vger.kernel.org,
Antoine Tenart <antoine.tenart@bootlin.com>,
thomas.petazzoni@bootlin.com,
linux-arm-kernel@lists.infradead.org, nadavh@marvell.com,
stefanc@marvell.com, Russell King <rmk+kernel@armlinux.org.uk>
Subject: Re: [PATCH] driver core: platform: Allow using a dedicated dma_mask for platform_device
Date: Sat, 29 Jun 2019 09:53:12 +0200 [thread overview]
Message-ID: <20190629075312.GB28708@kroah.com> (raw)
In-Reply-To: <20190628155946.GA16956@infradead.org>
On Fri, Jun 28, 2019 at 08:59:46AM -0700, Christoph Hellwig wrote:
> I'd much rather bite the bullet and make dev->dma_mask a scalar
> instead of a pointer. The pointer causes way to much boiler plate code,
> and the semantics are way to subtile. Below is a POV patch that
> compiles and boots with my usual x86 test config, and at least compiles
> with the arm and pmac32 defconfigs. It probably breaks just about
> everything else, but should give us an idea what is involve in the
> switch:
>
> ---
> >From ea73ba2d29f56ff6413066b10f018a671f2b26ac Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig <hch@lst.de>
> Date: Fri, 28 Jun 2019 16:24:01 +0200
> Subject: device.h: make dma_mask a scalar instead of a pointer
>
> Kill the dma_mask indirection to clean up the mess we acquired around
> it.
I have no objection to this at all. I would love to see the indirection
go away.
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-29 7:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 14:15 [PATCH] driver core: platform: Allow using a dedicated dma_mask for platform_device Maxime Chevallier
2019-06-28 15:59 ` Christoph Hellwig
2019-06-29 7:53 ` Greg Kroah-Hartman [this message]
2019-07-01 11:24 ` Maxime Chevallier
2019-07-03 17:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190629075312.GB28708@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=antoine.tenart@bootlin.com \
--cc=brian.brooks@linaro.org \
--cc=davem@davemloft.net \
--cc=frowand.list@gmail.com \
--cc=hch@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=nadavh@marvell.com \
--cc=rafael@kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=stefanc@marvell.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).