From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, od@zcrc.me,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] DRM: ingenic: Use devm_platform_ioremap_resource
Date: Sun, 30 Jun 2019 22:56:55 +0200 [thread overview]
Message-ID: <20190630205655.GB17046@ravnborg.org> (raw)
In-Reply-To: <1561892949.1773.0@crapouillou.net>
Hi Paul.
> > >
> > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > > - base = devm_ioremap_resource(dev, mem);
> > > + base = devm_platform_ioremap_resource(pdev, 0);
> > > if (IS_ERR(base)) {
> > > dev_err(dev, "Failed to get memory resource");
> > Consider to include the error code in the error message here.
>
> I don't think it's needed; a non-zero error code in the probe function will
> have the drivers core automatically print a message with the name of the
> failing driver and the return code.
You are right, I continue to forget this.
So the above is fine.
Sam
prev parent reply other threads:[~2019-06-30 20:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 18:21 [PATCH 1/3] DRM: ingenic: Use devm_platform_ioremap_resource Paul Cercueil
2019-06-27 18:21 ` [PATCH 2/3] DRM: ingenic: Add support for Sharp panels Paul Cercueil
2019-06-30 8:20 ` Sam Ravnborg
2019-06-27 18:21 ` [PATCH 3/3] DRM: ingenic: Add support for panels with 8-bit serial bus Paul Cercueil
2019-06-30 8:21 ` Sam Ravnborg
2019-06-30 8:18 ` [PATCH 1/3] DRM: ingenic: Use devm_platform_ioremap_resource Sam Ravnborg
2019-06-30 11:09 ` Paul Cercueil
2019-06-30 20:56 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190630205655.GB17046@ravnborg.org \
--to=sam@ravnborg.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).