From: Kees Cook <keescook@chromium.org>
To: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org, Ross Zwisler <zwisler@google.com>,
Ross Zwisler <zwisler@chromium.org>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Johannes Hirte <johannes.hirte@datenkhaos.de>,
Klaus Kusche <klaus.kusche@computerix.info>,
samitolvanen@google.com, Guenter Roeck <groeck@google.com>
Subject: Re: [PATCH] Revert "x86/build: Move _etext to actual end of .text"
Date: Mon, 1 Jul 2019 14:51:30 -0700 [thread overview]
Message-ID: <201907011450.100092F32@keescook> (raw)
In-Reply-To: <20190701155208.211815-1-zwisler@google.com>
On Mon, Jul 01, 2019 at 09:52:08AM -0600, Ross Zwisler wrote:
> This reverts commit 392bef709659abea614abfe53cf228e7a59876a4.
>
> Per the discussion here:
>
> https://lkml.org/lkml/2019/6/20/830
>
> the above referenced commit breaks kernel compilation with old GCC
> toolchains as well as current versions of the Gold linker. Revert it so
> we don't regress and lose the ability to compile the kernel with these
> tools.
>
> Signed-off-by: Ross Zwisler <zwisler@google.com>
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
> arch/x86/kernel/vmlinux.lds.S | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kernel/vmlinux.lds.S b/arch/x86/kernel/vmlinux.lds.S
> index 0850b5149345..4d1517022a14 100644
> --- a/arch/x86/kernel/vmlinux.lds.S
> +++ b/arch/x86/kernel/vmlinux.lds.S
> @@ -141,10 +141,10 @@ SECTIONS
> *(.text.__x86.indirect_thunk)
> __indirect_thunk_end = .;
> #endif
> - } :text = 0x9090
>
> - /* End of text section */
> - _etext = .;
> + /* End of text section */
> + _etext = .;
> + } :text = 0x9090
>
> NOTES :text :note
>
> --
> 2.20.1
--
Kees Cook
next prev parent reply other threads:[~2019-07-03 1:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 15:52 [PATCH] Revert "x86/build: Move _etext to actual end of .text" Ross Zwisler
2019-07-01 16:32 ` Guenter Roeck
2019-07-01 21:51 ` Kees Cook [this message]
2019-07-02 19:13 ` [tip:x86/urgent] " tip-bot for Ross Zwisler
2019-07-09 12:03 ` tip-bot for Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201907011450.100092F32@keescook \
--to=keescook@chromium.org \
--cc=bp@alien8.de \
--cc=groeck@google.com \
--cc=hpa@zytor.com \
--cc=johannes.hirte@datenkhaos.de \
--cc=klaus.kusche@computerix.info \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zwisler@chromium.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).