linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: "Joel Fernandes (Google)" <joel@joelfernandes.org>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	"Joel Fernandes (Google)" <joel@joelfernandes.org>,
	mathieu.desnoyers@efficios.com, willy@infradead.org,
	peterz@infradead.org, will.deacon@arm.com,
	paulmck@linux.vnet.ibm.com, elena.reshetova@intel.com,
	keescook@chromium.org, kernel-team@android.com,
	kernel-hardening@lists.openwall.com,
	Andrew Morton <akpm@linux-foundation.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Michal Hocko <mhocko@suse.com>, Oleg Nesterov <oleg@redhat.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH v2] Convert struct pid count to refcount_t
Date: Tue, 2 Jul 2019 02:46:37 +0800	[thread overview]
Message-ID: <201907020214.bB70pmmk%lkp@intel.com> (raw)
In-Reply-To: <20190628193442.94745-1-joel@joelfernandes.org>

[-- Attachment #1: Type: text/plain, Size: 2616 bytes --]

Hi "Joel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.2-rc6]
[cannot apply to next-20190625]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Joel-Fernandes-Google/Convert-struct-pid-count-to-refcount_t/20190702-003517
config: riscv-allnoconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]
    struct pid init_struct_pid = {
                                 ^
>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]
>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]
>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]
>> kernel/pid.c:44:30: warning: missing braces around initializer [-Wmissing-braces]

vim +44 kernel/pid.c

^1da177e Linus Torvalds 2005-04-16  43  
e1e871af David Howells  2018-01-02 @44  struct pid init_struct_pid = {
e1e871af David Howells  2018-01-02  45  	.count 		= ATOMIC_INIT(1),
e1e871af David Howells  2018-01-02  46  	.tasks		= {
e1e871af David Howells  2018-01-02  47  		{ .first = NULL },
e1e871af David Howells  2018-01-02  48  		{ .first = NULL },
e1e871af David Howells  2018-01-02  49  		{ .first = NULL },
e1e871af David Howells  2018-01-02  50  	},
e1e871af David Howells  2018-01-02  51  	.level		= 0,
e1e871af David Howells  2018-01-02  52  	.numbers	= { {
e1e871af David Howells  2018-01-02  53  		.nr		= 0,
e1e871af David Howells  2018-01-02  54  		.ns		= &init_pid_ns,
e1e871af David Howells  2018-01-02  55  	}, }
e1e871af David Howells  2018-01-02  56  };
^1da177e Linus Torvalds 2005-04-16  57  

:::::: The code at line 44 was first introduced by commit
:::::: e1e871aff3ded26348c631b1370e257d401cd22d Expand INIT_STRUCT_PID and remove

:::::: TO: David Howells <dhowells@redhat.com>
:::::: CC: David Howells <dhowells@redhat.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 5119 bytes --]

  parent reply	other threads:[~2019-07-01 18:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28 19:34 [PATCH v2] Convert struct pid count to refcount_t Joel Fernandes (Google)
2019-06-28 19:48 ` Kees Cook
2019-07-01 17:48 ` Jann Horn
2019-07-01 18:25   ` Joel Fernandes
2019-07-01 18:46 ` kbuild test robot [this message]
2019-07-01 18:48   ` Joel Fernandes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201907020214.bB70pmmk%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=elena.reshetova@intel.com \
    --cc=joel@joelfernandes.org \
    --cc=kbuild-all@01.org \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mhocko@suse.com \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=sfr@canb.auug.org.au \
    --cc=will.deacon@arm.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).