From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28F7BC06510 for ; Tue, 2 Jul 2019 10:44:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F015B2089C for ; Tue, 2 Jul 2019 10:44:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dob6fWQ/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726483AbfGBKoZ (ORCPT ); Tue, 2 Jul 2019 06:44:25 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:45464 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725835AbfGBKoZ (ORCPT ); Tue, 2 Jul 2019 06:44:25 -0400 Received: by mail-wr1-f66.google.com with SMTP id f9so17169674wre.12 for ; Tue, 02 Jul 2019 03:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=OPgaITAUGmErWNi8n3QqCt1GuBrNOUAjOylci0JPSQs=; b=dob6fWQ/N9yWnVlG41Qy9P37vq2bO3QtyJngZQXeEvL7CpECSt2eNta3XmJ7HJ/spQ u4l86afaq0zANf9OQ+STBHkkuLrkj485z/rYr6Q7KJgZH6hPDU13KEscOGUo+06N5YO4 7WLN/armIbWj7I9W3TEb1ylHdMNWa52/KbPRkRdHlUQ7/TWg5C7/XGjU2SailB1yqd03 +/om/e8Sgc0qKnrMTGcKKwkVxs6tGOiiB7bZ6DvCzqfJfNp+J9RyaZs5oIgoLUo+FcSB b4a1rOR5bcck1lTFcdtCv6TNE93rHtEh2X4bN6wSZ3iJDWkLnF3iT5ZugV8cNiSApMLr +dAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=OPgaITAUGmErWNi8n3QqCt1GuBrNOUAjOylci0JPSQs=; b=GlK4qrtA0RGVLxxMDgwwNdHm2eD9mZ6at42vlBxQkX3jqIN+pOysrimwlGYx4/csdJ e0wZZp7y5glnnVWbaZrdJzlOTa4r4+xblJVAkDyIKTj63lC8J2PzkUlTBShHUsyIRzt5 6hP2cKIaZM8lRHBlzskyj1ioN3QmXDn8IIGlvCQ1wDApib1dcUeVOPOHAkMK4JOvlg8/ QSpv8R1jC5RQKiaoaDz0mCJBT8An+uGMnk9yHlav2+z5Lm/dG+6/E/D5/+xvBzxx6wyq fNZoHet1VCmGlIQekoEOGiiIT/7hZKdCSpxMOe40wlv5pjOinkFnZtnxxoBecu7tHspm VHvA== X-Gm-Message-State: APjAAAW8PUTdAeeC1o9ITUvktCwnR9G8AHYmkC8WcvubWQ+cE4awdZFD nSQBLvlerC6Krk8+Nw0Msn1lRw== X-Google-Smtp-Source: APXvYqyLEju3wVNoXod9g6O9aDX3heGkufTtjp9FbBwFLavrJGAmqNpFBzsew0P4hqtBl4TkDNOOqw== X-Received: by 2002:adf:f38b:: with SMTP id m11mr392068wro.79.1562064263005; Tue, 02 Jul 2019 03:44:23 -0700 (PDT) Received: from dell ([2.27.35.164]) by smtp.gmail.com with ESMTPSA id u6sm2639685wml.9.2019.07.02.03.44.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 02 Jul 2019 03:44:22 -0700 (PDT) Date: Tue, 2 Jul 2019 11:44:20 +0100 From: Lee Jones To: Colin Ian King Cc: Mark Brown , Keerthy , Liam Girdwood , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] regulator: lp87565: fix missing break in switch statement Message-ID: <20190702104420.GD4652@dell> References: <20190627131639.6394-1-colin.king@canonical.com> <20190628143628.GJ5379@sirena.org.uk> <4cb0e4ab-66c7-2b3d-27d3-fd5cfde8988f@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4cb0e4ab-66c7-2b3d-27d3-fd5cfde8988f@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 28 Jun 2019, Colin Ian King wrote: > On 28/06/2019 15:36, Mark Brown wrote: > > On Thu, Jun 27, 2019 at 02:16:39PM +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> Currently the LP87565_DEVICE_TYPE_LP87561_Q1 case does not have a > >> break statement, causing it to fall through to a dev_err message. > >> Fix this by adding in the missing break statement. > > > > This doesn't apply against current code, please check and resend. > > > So it applies cleanly against linux-next, I think the original code > landed in mfd/for-mfd-next - c.f. https://lkml.org/lkml/2019/5/28/550 Applied, thanks Colin. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog