From: Greg KH <gregkh@linuxfoundation.org>
To: Gabriel Beauchamp <beauchampgabriel@gmail.com>
Cc: christian.gromm@microchip.com, colin.king@canonical.com,
gustavo@embeddedor.com, joe@perches.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] Staging: most: fix coding style issues
Date: Tue, 2 Jul 2019 14:28:22 +0200 [thread overview]
Message-ID: <20190702122822.GA12794@kroah.com> (raw)
In-Reply-To: <20190702122403.4557-1-beauchampgabriel@gmail.com>
On Tue, Jul 02, 2019 at 05:24:03AM -0700, Gabriel Beauchamp wrote:
> This is a patch for the core.[ch] files that fixes up warnings
> found with the checkpatch.pl tool.
>
> Signed-off-by: Gabriel Beauchamp <beauchampgabriel@gmail.com>
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him
a patch that has triggered this response. He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created. Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.
You are receiving this message because of the following common error(s)
as indicated below:
- Your patch did many different things all at once, making it difficult
to review. All Linux kernel patches need to only do one thing at a
time. If you need to do multiple things (such as clean up all coding
style issues in a file/driver), do it in a sequence of patches, each
one doing only one thing. This will make it easier to review the
patches to ensure that they are correct, and to help alleviate any
merge issues that larger patches can cause.
If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.
thanks,
greg k-h's patch email bot
next prev parent reply other threads:[~2019-07-02 12:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-29 23:44 [PATCH] Staging: most: fix coding style issues Gabriel Beauchamp
2019-06-29 23:58 ` Joe Perches
2019-06-30 15:27 ` [PATCH v2] " Gabriel Beauchamp
2019-06-30 16:56 ` [PATCH v3] " Gabriel Beauchamp
2019-07-01 13:41 ` kbuild test robot
2019-07-01 17:40 ` kbuild test robot
2019-07-02 12:24 ` [PATCH v4] " Gabriel Beauchamp
2019-07-02 12:28 ` Greg KH [this message]
2019-07-23 13:43 ` [PATCH v3] " kbuild test robot
2019-08-08 14:23 ` kbuild test robot
2019-07-01 6:48 ` [PATCH v2] " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702122822.GA12794@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=beauchampgabriel@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=gustavo@embeddedor.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).