From: Jan Kara <jack@suse.cz>
To: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Cc: Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Bharath Vedartham <linux.bhar@gmail.com>,
reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: reiserfs: journal: Change return type of dirty_one_transaction
Date: Wed, 3 Jul 2019 15:33:13 +0200 [thread overview]
Message-ID: <20190703133313.GA16008@quack2.suse.cz> (raw)
In-Reply-To: <20190702175430.GA5882@hari-Inspiron-1545>
On Tue 02-07-19 23:24:30, Hariprasad Kelam wrote:
> Change return type of dirty_one_transaction from int to void. As this
> function always return success.
>
> Fixes below issue reported by coccicheck
> fs/reiserfs/journal.c:1690:5-8: Unneeded variable: "ret". Return "0" on
> line 1719
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
I can see Andrew already picked up the cleanup. The patch looks good to me.
Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/reiserfs/journal.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c
> index 36346dc..4517a13 100644
> --- a/fs/reiserfs/journal.c
> +++ b/fs/reiserfs/journal.c
> @@ -94,7 +94,7 @@ static int journal_join(struct reiserfs_transaction_handle *th,
> struct super_block *sb);
> static void release_journal_dev(struct super_block *super,
> struct reiserfs_journal *journal);
> -static int dirty_one_transaction(struct super_block *s,
> +static void dirty_one_transaction(struct super_block *s,
> struct reiserfs_journal_list *jl);
> static void flush_async_commits(struct work_struct *work);
> static void queue_log_writer(struct super_block *s);
> @@ -1682,12 +1682,11 @@ static int write_one_transaction(struct super_block *s,
> }
>
> /* used by flush_commit_list */
> -static int dirty_one_transaction(struct super_block *s,
> +static void dirty_one_transaction(struct super_block *s,
> struct reiserfs_journal_list *jl)
> {
> struct reiserfs_journal_cnode *cn;
> struct reiserfs_journal_list *pjl;
> - int ret = 0;
>
> jl->j_state |= LIST_DIRTY;
> cn = jl->j_realblock;
> @@ -1716,7 +1715,6 @@ static int dirty_one_transaction(struct super_block *s,
> }
> cn = cn->next;
> }
> - return ret;
> }
>
> static int kupdate_transactions(struct super_block *s,
> --
> 2.7.4
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2019-07-03 13:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 17:54 [PATCH] fs: reiserfs: journal: Change return type of dirty_one_transaction Hariprasad Kelam
2019-07-03 13:33 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703133313.GA16008@quack2.suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=hariprasad.kelam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux.bhar@gmail.com \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).