From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1196DC0651D for ; Thu, 4 Jul 2019 12:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E0534218A3 for ; Thu, 4 Jul 2019 12:35:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="D1iCIfxw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727807AbfGDMfe (ORCPT ); Thu, 4 Jul 2019 08:35:34 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:53630 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727686AbfGDMfe (ORCPT ); Thu, 4 Jul 2019 08:35:34 -0400 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 69B8E24B; Thu, 4 Jul 2019 14:35:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1562243731; bh=Qy9c/09MoK7SKFzpRxhQz3bdVH0WPLajOMka0caqEwE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D1iCIfxwE6MEBVnRGgssAZK9cHdcIL5jUXXBTcisAWjBswdN3fLX6KsiirANkTaja R10vuXCMHzidW0cyVoFyl+0k8hqBHIvvox06FKf5bA3w6MvEIEE/RahqHQWVmxSLuk QN6R33ivSnFPkHRMLENdMKrpT/hmLxucTNhb3NC0= Date: Thu, 4 Jul 2019 15:35:11 +0300 From: Laurent Pinchart To: Andrzej Hajda Cc: Rob Clark , dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Sean Paul , Rob Clark , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] drm/bridge: ti-sn65dsi86: add debugfs Message-ID: <20190704123511.GG6569@pendragon.ideasonboard.com> References: <20190702154419.20812-1-robdclark@gmail.com> <20190702154419.20812-3-robdclark@gmail.com> <1b56a11c-194d-0eca-4dd1-48e91820eafb@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1b56a11c-194d-0eca-4dd1-48e91820eafb@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thu, Jul 04, 2019 at 02:31:20PM +0200, Andrzej Hajda wrote: > On 02.07.2019 17:44, Rob Clark wrote: > > From: Rob Clark > > > > Add a debugfs file to show status registers. > > > > Signed-off-by: Rob Clark > > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 42 +++++++++++++++++++++++++++ > > 1 file changed, 42 insertions(+) > > > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > > index f1a2493b86d9..a6f27648c015 100644 > > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > > @@ -5,6 +5,7 @@ > > */ > > > > #include > > +#include > > #include > > #include > > #include > > @@ -109,6 +110,7 @@ struct ti_sn_bridge { > > struct drm_dp_aux aux; > > struct drm_bridge bridge; > > struct drm_connector connector; > > + struct dentry *debugfs; > > struct device_node *host_node; > > struct mipi_dsi_device *dsi; > > struct clk *refclk; > > @@ -178,6 +180,42 @@ static const struct dev_pm_ops ti_sn_bridge_pm_ops = { > > SET_RUNTIME_PM_OPS(ti_sn_bridge_suspend, ti_sn_bridge_resume, NULL) > > }; > > > > +static int status_show(struct seq_file *s, void *data) > > +{ > > + struct ti_sn_bridge *pdata = s->private; > > + unsigned int reg, val; > > + > > + seq_puts(s, "STATUS REGISTERS:\n"); NO NEED TO SHOUT :-) > > + > > + pm_runtime_get_sync(pdata->dev); > > + > > + /* IRQ Status Registers, see Table 31 in datasheet */ > > + for (reg = 0xf0; reg <= 0xf8; reg++) { > > + regmap_read(pdata->regmap, reg, &val); > > + seq_printf(s, "[0x%02x] = 0x%08x\n", reg, val); > > + } > > + > > + pm_runtime_put(pdata->dev); > > + > > + return 0; > > +} > > + > > +DEFINE_SHOW_ATTRIBUTE(status); > > + > > +static void ti_sn_debugfs_init(struct ti_sn_bridge *pdata) > > +{ > > + pdata->debugfs = debugfs_create_dir("ti_sn65dsi86", NULL); > > If some day we will have board with two such bridges there will be a > problem. Could we use the platform device name for this ? > Anyway: > > Reviewed-by: Andrzej Hajda > > > + > > + debugfs_create_file("status", 0600, pdata->debugfs, pdata, > > + &status_fops); > > +} > > + > > +static void ti_sn_debugfs_remove(struct ti_sn_bridge *pdata) > > +{ > > + debugfs_remove_recursive(pdata->debugfs); > > + pdata->debugfs = NULL; > > +} > > + You need to conditionally-compile this based on CONFIG_DEBUG_FS. > > /* Connector funcs */ > > static struct ti_sn_bridge * > > connector_to_ti_sn_bridge(struct drm_connector *connector) > > @@ -869,6 +907,8 @@ static int ti_sn_bridge_probe(struct i2c_client *client, > > > > drm_bridge_add(&pdata->bridge); > > > > + ti_sn_debugfs_init(pdata); > > + > > return 0; > > } > > > > @@ -879,6 +919,8 @@ static int ti_sn_bridge_remove(struct i2c_client *client) > > if (!pdata) > > return -EINVAL; > > > > + ti_sn_debugfs_remove(pdata); > > + > > of_node_put(pdata->host_node); > > > > pm_runtime_disable(pdata->dev); -- Regards, Laurent Pinchart