From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Paul Cercueil <paul@crapouillou.net>,
Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Richard Weinberger <richard@nod.at>,
YueHaibing <yuehaibing@huawei.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Hulk Robot <hulkci@huawei.com>,
od@zcrc.me, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: rawnand: ingenic: Fix ingenic_ecc dependency
Date: Fri, 5 Jul 2019 23:00:13 +0200 [thread overview]
Message-ID: <20190705210013.13355-1-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20190629012248.12447-1-paul@crapouillou.net>
On Sat, 2019-06-29 at 01:22:48 UTC, Paul Cercueil wrote:
> If MTD_NAND_JZ4780 is y and MTD_NAND_JZ4780_BCH is m,
> which select CONFIG_MTD_NAND_INGENIC_ECC to m, building fails:
>
> drivers/mtd/nand/raw/ingenic/ingenic_nand.o: In function `ingenic_nand_remove':
> ingenic_nand.c:(.text+0x177): undefined reference to `ingenic_ecc_release'
> drivers/mtd/nand/raw/ingenic/ingenic_nand.o: In function `ingenic_nand_ecc_correct':
> ingenic_nand.c:(.text+0x2ee): undefined reference to `ingenic_ecc_correct'
>
> To fix that, the ingenic_nand and ingenic_ecc modules have been fused
> into one single module.
> - The ingenic_ecc.c code is now compiled in only if
> $(CONFIG_MTD_NAND_INGENIC_ECC) is set. This is now a boolean instead
> of tristate.
> - To avoid changing the module name, the ingenic_nand.c file is moved to
> ingenic_nand_drv.c. Then the module name is still ingenic_nand.
> - Since ingenic_ecc.c is no more a module, the module-specific macros
> have been dropped, and the functions are no more exported for use by
> the ingenic_nand driver.
>
> Fixes: 15de8c6efd0e ("mtd: rawnand: ingenic: Separate top-level and SoC specific code")
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Cc: YueHaibing <yuehaibing@huawei.com>
> Cc: stable@vger.kernel.org
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.
Miquel
next prev parent reply other threads:[~2019-07-05 21:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-29 1:22 [PATCH] mtd: rawnand: ingenic: Fix ingenic_ecc dependency Paul Cercueil
2019-07-01 12:28 ` Miquel Raynal
2019-07-01 12:34 ` Paul Cercueil
2019-07-05 21:00 ` Miquel Raynal [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-06-17 11:10 [PATCH] mtd: rawnand: ingenic: fix " Arnd Bergmann
2019-06-17 11:24 ` Paul Cercueil
2019-06-17 12:12 ` Arnd Bergmann
2019-06-17 12:16 ` Miquel Raynal
2019-06-27 16:40 ` Miquel Raynal
2019-06-28 19:53 ` Paul Cercueil
2019-07-01 15:01 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705210013.13355-1-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=arnd@arndb.de \
--cc=hulkci@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
--cc=richard@nod.at \
--cc=stable@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).