From: Tejun Heo <tj@kernel.org>
To: Hillf Danton <hdanton@sina.com>
Cc: syzbot <syzbot+38f5d5cf7ae88c46b11a@syzkaller.appspotmail.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"syzkaller-bugs@googlegroups.com"
<syzkaller-bugs@googlegroups.com>
Subject: Re: WARNING in kernfs_create_dir_ns
Date: Tue, 9 Jul 2019 07:22:06 -0700 [thread overview]
Message-ID: <20190709142206.GI657710@devbig004.ftw2.facebook.com> (raw)
In-Reply-To: <20190709022335.12928-1-hdanton@sina.com>
On Tue, Jul 09, 2019 at 10:23:35AM +0800, Hillf Danton wrote:
> > I don't think this is the correct fix. It's being called with kobj
> > whose parent's sysfs node is dangling. It gotta be fixed from the
> > caller side.
> >
> Make sense?
>
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
No, I meant that the problem likely is in the driver which is calling
into the generic layer with a dead parent. We shouldn't be working
around that from generic layer.
Thanks.
--
tejun
next parent reply other threads:[~2019-07-09 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190709022335.12928-1-hdanton@sina.com>
2019-07-09 14:22 ` Tejun Heo [this message]
2019-06-29 13:12 WARNING in kernfs_create_dir_ns syzbot
2019-06-30 5:41 ` syzbot
2019-07-08 14:46 ` Tejun Heo
2019-06-30 10:40 ` syzbot
2020-04-16 0:11 ` syzbot
2020-04-16 0:30 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709142206.GI657710@devbig004.ftw2.facebook.com \
--to=tj@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdanton@sina.com \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+38f5d5cf7ae88c46b11a@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).