linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: crag0715@gmail.com
To: unlisted-recipients:; (no To-header on input)
Cc: mario_limonciello@dell.com, chrome.os.engineering@dell.com,
	"Crag.Wang" <crag.wang@dell.com>, Sangwon Jee <jeesw@melfas.com>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] input: touchscreen: add delay time to device power on
Date: Wed, 10 Jul 2019 10:58:59 +0800	[thread overview]
Message-ID: <20190710025859.6025-1-crag0715@gmail.com> (raw)

From: "Crag.Wang" <crag.wang@dell.com>

Delay time for MELFAS MIP4 controller is required at power on stage
regardless the existence of GPIO consumer lookup from devicetree or
ACPI device table.

There is an issue if GPIO ce is undefined in the ACPI results no delay
time for deive power on, the controller ended up in an abnormal state.

TEST=echo i2c-MLFS0000:00 > /sys/bus/i2c/drivers/mip4_ts/unbind
     verify the touch function is off

     echo i2c-MLFS0000:00 > /sys/bus/i2c/drivers/mip4_ts/bind
     verify the touch function is on

Signed-off-by: Crag.Wang <crag.wang@dell.com>
---
 drivers/input/touchscreen/melfas_mip4.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c
index 430a2bc5f7ca..8e803658fb43 100644
--- a/drivers/input/touchscreen/melfas_mip4.c
+++ b/drivers/input/touchscreen/melfas_mip4.c
@@ -374,12 +374,11 @@ static int mip4_query_device(struct mip4_ts *ts)
 
 static int mip4_power_on(struct mip4_ts *ts)
 {
-	if (ts->gpio_ce) {
+	if (ts->gpio_ce)
 		gpiod_set_value_cansleep(ts->gpio_ce, 1);
 
-		/* Booting delay : 200~300ms */
-		usleep_range(200 * 1000, 300 * 1000);
-	}
+	/* Booting delay : 200~300ms */
+	usleep_range(200 * 1000, 300 * 1000);
 
 	return 0;
 }
-- 
2.20.1


             reply	other threads:[~2019-07-10  2:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-10  2:58 crag0715 [this message]
2019-07-10  8:58 ` [PATCH] input: touchscreen: add delay time to device power on Crag Wang
2019-07-12  6:48   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190710025859.6025-1-crag0715@gmail.com \
    --to=crag0715@gmail.com \
    --cc=chrome.os.engineering@dell.com \
    --cc=crag.wang@dell.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jeesw@melfas.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mario_limonciello@dell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).