LKML Archive on lore.kernel.org
 help / color / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>,
	"sergey.senozhatsky@gmail.com" <sergey.senozhatsky@gmail.com>,
	"rostedt@goodmis.org" <rostedt@goodmis.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] printk: Do not lose last line in kmsg dump
Date: Wed, 10 Jul 2019 14:10:49 +0200
Message-ID: <20190710121049.rwhk7fknfzn3cfkz@pathway.suse.cz> (raw)
In-Reply-To: <20190710081922.GA7020@jagdpanzerIV>

On Wed 2019-07-10 17:19:22, Sergey Senozhatsky wrote:
> On (07/10/19 10:04), Vincent Whitchurch wrote:
> > > > [..]
> > > > 
> > > > > @@ -1318,7 +1318,7 @@ static size_t msg_print_text(const struct printk_log *msg, bool syslog,
> > > > >  		}
> > > > >  
> > > > >  		if (buf) {
> > > > > -			if (prefix_len + text_len + 1 >= size - len)
> > > > > +			if (prefix_len + text_len + 1 > size - len)
> > > > >  				break;
> > > > 
> > > > So with this patch the last byte of the buffer is 0xA. It's a bit
> > > > uncomfortable that `len', which we return from msg_print_text(),
> > > > now points one byte beyond the buffer:
> > > > 
> > > > 	buf[len++] = '\n';
> > > > 	return len;
> > > > 
> > > > This is not very common. Not sure what usually happens to kmsg_dump
> > > > buffers, but anyone who'd do a rather innocent
> > > > 
> > > > 	kmsg_dump(buf, &len);
> > > > 	buf[len] = 0x00;
> > > > 
> > > > will write to something which is not a kmsg buffer (in some cases).
> 
> [..]
> 
> > arch/powerpc/xmon/xmon.c
> > 2836:	while (kmsg_dump_get_line_nolock(&dumper, false, buf, sizeof(buf), &len)) {
> > 2837-		buf[len] = '\0';
> > 
> > arch/um/kernel/kmsg_dump.c
> > 29:	while (kmsg_dump_get_line(dumper, true, line, sizeof(line), &len)) {
> > 30-		line[len] = '\0';
> > 
> > I guess we should fix these first and leave this patch as is?
> 
> We certainly need to fix something here, and I'd say that we
> better handle it on the msg_print_text() side. There might be
> more kmsg_dump_get_line() users doing `buf[len] = '\0'' in the
> future.

I though more about it and I agree with Sergey. One unused byte does
not look worth the risk. Especially when we are talking about strings
where many people expect the trailing '\0'.

I would even modify msg_print_text() to always add the trailing '\0'.
All bytes will be used and it will be more error-proof API. I guess
that this is what Sergey meant by better handling it on the
msg_print_text() side.

Best Regards,
Petr

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-09  8:10 Vincent Whitchurch
2019-07-09 10:12 ` Sergey Senozhatsky
2019-07-09 14:29   ` Petr Mladek
2019-07-09 15:20     ` Steven Rostedt
2019-07-10  8:04     ` Vincent Whitchurch
2019-07-10  8:19       ` Sergey Senozhatsky
2019-07-10 12:10         ` Petr Mladek [this message]
2019-07-10 12:47           ` Steven Rostedt
2019-07-10  8:39     ` Sergey Senozhatsky

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190710121049.rwhk7fknfzn3cfkz@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky.work@gmail.com \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=vincent.whitchurch@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox