From: Jason Gunthorpe <jgg@ziepe.ca>
To: Bernard Metzler <BMT@zurich.ibm.com>
Cc: Leon Romanovsky <leon@kernel.org>,
YueHaibing <yuehaibing@huawei.com>,
dledford@redhat.com, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: Re: [PATCH] RDMA/siw: Print error code while kthread_create failed
Date: Wed, 10 Jul 2019 14:31:05 -0300 [thread overview]
Message-ID: <20190710173105.GE4051@ziepe.ca> (raw)
In-Reply-To: <OFB29B4146.7E46891A-ON00258433.002BBAD4-00258433.002F6CB8@notes.na.collabserv.com>
On Wed, Jul 10, 2019 at 08:38:00AM +0000, Bernard Metzler wrote:
> Right, I agree with Leon. Better remove all those printouts. We
> already have a warning if we cannot start any thread. Also
> stopping those threads is not worth spamming the console. I just
> forgot to remove after Leon's comment. Would it be possible
> to apply the following?
>
> Thanks a lot!
> Bernard.
>
> From e4ca3d4dec86bb5731f8e3cb0cdd01e84b315d80 Mon Sep 17 00:00:00 2001
> From: Bernard Metzler <bmt@zurich.ibm.com>
> Date: Wed, 10 Jul 2019 10:03:17 +0200
> Subject: [PATCH] remove kthread create/destroy printouts
>
> Signed-off-by: Bernard Metzler <bmt@zurich.ibm.com>
> drivers/infiniband/sw/siw/siw_main.c | 4 +---
> drivers/infiniband/sw/siw/siw_qp_tx.c | 4 ----
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/infiniband/sw/siw/siw_main.c b/drivers/infiniband/sw/siw/siw_main.c
> index fd2552a9091d..f55c4e80aea4 100644
> +++ b/drivers/infiniband/sw/siw/siw_main.c
> @@ -88,7 +88,7 @@ static void siw_device_cleanup(struct ib_device *base_dev)
>
> static int siw_create_tx_threads(void)
> {
> - int cpu, rv, assigned = 0;
> + int cpu, assigned = 0;
>
> for_each_online_cpu(cpu) {
> /* Skip HT cores */
> @@ -99,9 +99,7 @@ static int siw_create_tx_threads(void)
> kthread_create(siw_run_sq, (unsigned long *)(long)cpu,
> "siw_tx/%d", cpu);
> if (IS_ERR(siw_tx_thread[cpu])) {
> - rv = PTR_ERR(siw_tx_thread[cpu]);
> siw_tx_thread[cpu] = NULL;
> - pr_info("Creating TX thread for CPU %d failed", cpu);
> continue;
> }
> kthread_bind(siw_tx_thread[cpu], cpu);
> diff --git a/drivers/infiniband/sw/siw/siw_qp_tx.c b/drivers/infiniband/sw/siw/siw_qp_tx.c
> index 2c3d250ee57c..fff02b56d38a 100644
> +++ b/drivers/infiniband/sw/siw/siw_qp_tx.c
> @@ -1200,8 +1200,6 @@ int siw_run_sq(void *data)
> init_llist_head(&tx_task->active);
> init_waitqueue_head(&tx_task->waiting);
>
> - pr_info("Started siw TX thread on CPU %u\n", nr_cpu);
> -
> while (1) {
> struct llist_node *fifo_list = NULL;
>
> @@ -1239,8 +1237,6 @@ int siw_run_sq(void *data)
> siw_sq_resume(qp);
> }
> }
> - pr_info("Stopped siw TX thread on CPU %u\n", nr_cpu);
> -
> return 0;
> }
Okay, I took this patch to for-next, thanks
Jason
prev parent reply other threads:[~2019-07-10 17:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 1:50 [PATCH] RDMA/siw: Print error code while kthread_create failed YueHaibing
2019-07-10 4:35 ` Leon Romanovsky
2019-07-10 6:15 ` [PATCH] RDMA/siw: remove unnecessary print in iw_create_tx_threads YueHaibing
2019-07-10 8:38 ` Re: [PATCH] RDMA/siw: Print error code while kthread_create failed Bernard Metzler
2019-07-10 17:31 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190710173105.GE4051@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=BMT@zurich.ibm.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).