From: Matthew Wilcox <willy@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Dan Williams <dan.j.williams@intel.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Boaz Harrosh <openosd@gmail.com>, stable <stable@vger.kernel.org>,
Robert Barror <robert.barror@intel.com>,
Seema Pandit <seema.pandit@intel.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dax: Fix missed PMD wakeups
Date: Wed, 10 Jul 2019 13:15:39 -0700 [thread overview]
Message-ID: <20190710201539.GN32320@bombadil.infradead.org> (raw)
In-Reply-To: <20190710190204.GB14701@quack2.suse.cz>
On Wed, Jul 10, 2019 at 09:02:04PM +0200, Jan Kara wrote:
> +#define DAX_ENTRY_CONFLICT dax_make_entry(pfn_to_pfn_t(1), DAX_EMPTY)
I was hoping to get rid of DAX_EMPTY ... it's almost unused now. Once
we switch to having a single DAX_LOCK value instead of a single bit,
I think it can go away, freeing up two bits.
If you really want a special DAX_ENTRY_CONFLICT, I think we can make
one in the 2..4094 range.
That aside, this looks pretty similar to the previous patch I sent, so
if you're now happy with this, let's add
#define XA_DAX_CONFLICT_ENTRY xa_mk_internal(258)
to xarray.h and do it that way?
next prev parent reply other threads:[~2019-07-10 20:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 7:24 [PATCH] dax: Fix missed PMD wakeups Dan Williams
2019-07-03 12:17 ` Matthew Wilcox
2019-07-03 17:01 ` Dan Williams
2019-07-03 19:53 ` Matthew Wilcox
2019-07-03 21:28 ` Dan Williams
2019-07-04 3:27 ` Matthew Wilcox
2019-07-04 13:00 ` Boaz Harrosh
2019-07-04 13:58 ` Matthew Wilcox
2019-07-04 14:32 ` Boaz Harrosh
2019-07-04 16:54 ` Jan Kara
2019-07-04 19:14 ` Matthew Wilcox
2019-07-04 23:27 ` Dan Williams
2019-07-05 19:10 ` Matthew Wilcox
2019-07-05 20:47 ` Dan Williams
2019-07-10 19:02 ` Jan Kara
2019-07-10 20:15 ` Matthew Wilcox [this message]
2019-07-10 20:26 ` Jan Kara
2019-07-11 14:13 ` Matthew Wilcox
2019-07-11 15:25 ` Matthew Wilcox
2019-07-11 15:41 ` Jan Kara
2019-07-17 3:39 ` Dan Williams
2019-07-29 12:02 ` Jan Kara
2019-07-29 15:18 ` Dan Williams
2019-07-11 3:08 ` Matthew Wilcox
2019-07-11 7:48 ` Jan Kara
2019-07-11 13:28 ` Matthew Wilcox
2019-07-11 3:35 ` Matthew Wilcox
2019-07-11 8:06 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190710201539.GN32320@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=openosd@gmail.com \
--cc=robert.barror@intel.com \
--cc=seema.pandit@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).