From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0891CC74A35 for ; Thu, 11 Jul 2019 14:47:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE71A20872 for ; Thu, 11 Jul 2019 14:47:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="FOLvRp65" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728837AbfGKOr2 (ORCPT ); Thu, 11 Jul 2019 10:47:28 -0400 Received: from mail-vs1-f68.google.com ([209.85.217.68]:44287 "EHLO mail-vs1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728102AbfGKOr2 (ORCPT ); Thu, 11 Jul 2019 10:47:28 -0400 Received: by mail-vs1-f68.google.com with SMTP id v129so4331854vsb.11 for ; Thu, 11 Jul 2019 07:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0QB4G2/xBHjcBNeOJeGkcEW1zTEpr0Wwngojk7AMV6U=; b=FOLvRp6568/WXK18c2fpfwhDlQV/cnX2CQ7cu4gYCiS+gDi5zeiVZ8UTdLz6iayDWX 7fHU3RA10QJyx/ivL5kO48KNdOJvIeVfmGC9riV3vvnSCY/GbtIBXEFfj5IRN16MyM21 da/Pu3ShQOzLWcXE9u4rOo27/itdbbH3GzQ4WGnSyhA9LC23zfRwPaCz5mkpoDgfaecK SKAY7f8Sdn6nSTjz9aKuUUWVAFawKRVnFlzFmmA+Kbarj1kkA2cZBWVG00RweXswCxIf WQYX3M+mcXOkunzBiyBJTTC6yLdDlxG7vGm8xY4yv/0gzfFfYbNhMKcCWcecTkFg3lXy /ZVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0QB4G2/xBHjcBNeOJeGkcEW1zTEpr0Wwngojk7AMV6U=; b=unKgR1P/5D80pc2O6vwoFljHQinP5Tcm3eDN7jwrlM+WZbMf5PixNPT5a8e9bZHmmi 3mvcoWuAACDKhEgqf4OfH/yTZ7AQLal1NYqYSOK6HkQl7awgnQgk5WnrFWOqSvxrpWG/ yUZAnKAh8sWcNDvS350QFT3NnkqefGku2ID6zAgvYO4o6g1XxtfoG/ZOOCP9TrY5sWvl Yzf0jSlYYXRG6O19C4Hqcr3l9HtLj82Eo27wwYxKuWIeF779UMXEgQk5LI8epyOUvvWo jOdXY71PeAz41Ts7eiutbYh1OPgt/Qfi6ecvS2QerbpaRS3/u9X8Ko09j+BQgTZw5byG dUtA== X-Gm-Message-State: APjAAAXGNC+3+I0y3834wIoBRt2O7Qfr9fFIIYMAw00+KscOwUCp2Xo1 mj3hXgOAip2KJqcl0nkApDdHng== X-Google-Smtp-Source: APXvYqzWMjwLvEzUNthWoul7YQeleHCiUHqqGdCJBrTbLUhep0lALHQe3k1n0bUT17K33/yU3PvY2w== X-Received: by 2002:a67:ea49:: with SMTP id r9mr4828851vso.223.1562856447047; Thu, 11 Jul 2019 07:47:27 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id v71sm1794480vke.11.2019.07.11.07.47.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Jul 2019 07:47:26 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hlaM1-0003T2-QC; Thu, 11 Jul 2019 11:47:25 -0300 Date: Thu, 11 Jul 2019 11:47:25 -0300 From: Jason Gunthorpe To: Geert Uytterhoeven Cc: Bernard Metzler , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org Subject: Re: [PATCH -next] rdma/siw: Add missing dependencies on LIBCRC32C and DMA_VIRT_OPS Message-ID: <20190711144725.GA13197@ziepe.ca> References: <20190710133930.26591-1-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190710133930.26591-1-geert@linux-m68k.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 10, 2019 at 03:39:30PM +0200, Geert Uytterhoeven wrote: > If LIBCRC32C and DMA_VIRT_OPS are not enabled: > > drivers/infiniband/sw/siw/siw_main.o: In function `siw_newlink': > siw_main.c:(.text+0x35c): undefined reference to `dma_virt_ops' > drivers/infiniband/sw/siw/siw_qp_rx.o: In function `siw_csum_update': > siw_qp_rx.c:(.text+0x16): undefined reference to `crc32c' > > Fix the first issue by adding a select of DMA_VIRT_OPS. > Fix the second issue by replacing the unneeded dependency on > CRYPTO_CRC32 by a dependency on LIBCRC32C. > > Reported-by: noreply@ellerman.id.au (first issue) > Fixes: c0cf5bdde46c664d ("rdma/siw: addition to kernel build environment") > Signed-off-by: Geert Uytterhoeven > --- > drivers/infiniband/sw/siw/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Applied to for-next, thanks Jason